[pLog-svn] r7119 - plog/branches/lifetype-1.2/class/view

Jon Daley plogworld at jon.limedaley.com
Tue Mar 1 12:07:41 EST 2011


error.php gets used in "Search Engine Friendly" mode, so you can't 
hard-code that to 404.

I'd actually like to get rid of all of the extra files in the root, and 
all the modrewrite rules in the .htaccess (and all the ForceType lines 
too) for a release some day.  I think every webhost supports the redirect 
to php script if static file not found syntax, so we no longer need all of 
this extra stuff, and then can do everything inside php.  At least we do 
that going forward, that new installations can only use "plain" urls or 
"custom urls", and we could start simplifying the code.  The 
so-called "search engine friendly" urls are no longer search engine 
friendly, so I don't know why anyone would use them, except for historical 
purposes.  And I think the code already fallsback to search engine 
friendly if a custom url isn't matched anyway.

On Tue, 1 Mar 2011, Andy Wright wrote:

> I don't see a reason why not.  However, I am sure their are cases that
> this is not the desired return code.  Would it be possible to apply this
> to the error handler, error.php instead of blog.php so that the blog
> administrators may direct such pages to one or the other as needed for
> their software systems?  Just a thought.
>
> On Mon, 2011-02-28 at 11:14 -0500, jondaley at devel.lifetype.net wrote:
>> Author: jondaley
>> Date: 2011-02-28 11:14:59 -0500 (Mon, 28 Feb 2011)
>> New Revision: 7119
>>
>> Modified:
>>    plog/branches/lifetype-1.2/class/view/errorview.class.php
>> Log:
>> add an 404 status on ALL error pages.  I know there was a discussion a while back about not returning 404s on dynamic URLs (index.php?asd=blah) but I can't find any references on the internet of if that is a bad thing.  Does anyone have a link to someone saying that is bad?  (I have an error_fetching_album page that is indexed higher than other pages, so I'm trying to get that out of the search engine index)
>>
>> Modified: plog/branches/lifetype-1.2/class/view/errorview.class.php
>> ===================================================================
>> --- plog/branches/lifetype-1.2/class/view/errorview.class.php	2011-02-28 15:47:09 UTC (rev 7118)
>> +++ plog/branches/lifetype-1.2/class/view/errorview.class.php	2011-02-28 16:14:59 UTC (rev 7119)
>> @@ -17,6 +17,7 @@
>>  		function ErrorView( $blogInfo, $message = null )
>>          {
>>          	$this->BlogView( $blogInfo, ERROR_TEMPLATE, SMARTY_VIEW_CACHE_DISABLED );
>> +			$this->addHeaderResponse( "HTTP/1.0 404" );
>>
>>              $this->_message = $message;
>>          }
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com
~~
What is originality? Undetected plagiarism.
-- Dean William R. Inge


More information about the pLog-svn mailing list