[pLog-svn] r7119 - plog/branches/lifetype-1.2/class/view

Andy Wright andy at extracted.org
Tue Mar 1 09:05:45 EST 2011


I don't see a reason why not.  However, I am sure their are cases that
this is not the desired return code.  Would it be possible to apply this
to the error handler, error.php instead of blog.php so that the blog
administrators may direct such pages to one or the other as needed for
their software systems?  Just a thought.

On Mon, 2011-02-28 at 11:14 -0500, jondaley at devel.lifetype.net wrote:
> Author: jondaley
> Date: 2011-02-28 11:14:59 -0500 (Mon, 28 Feb 2011)
> New Revision: 7119
> 
> Modified:
>    plog/branches/lifetype-1.2/class/view/errorview.class.php
> Log:
> add an 404 status on ALL error pages.  I know there was a discussion a while back about not returning 404s on dynamic URLs (index.php?asd=blah) but I can't find any references on the internet of if that is a bad thing.  Does anyone have a link to someone saying that is bad?  (I have an error_fetching_album page that is indexed higher than other pages, so I'm trying to get that out of the search engine index)
> 
> Modified: plog/branches/lifetype-1.2/class/view/errorview.class.php
> ===================================================================
> --- plog/branches/lifetype-1.2/class/view/errorview.class.php	2011-02-28 15:47:09 UTC (rev 7118)
> +++ plog/branches/lifetype-1.2/class/view/errorview.class.php	2011-02-28 16:14:59 UTC (rev 7119)
> @@ -17,6 +17,7 @@
>  		function ErrorView( $blogInfo, $message = null )
>          {
>          	$this->BlogView( $blogInfo, ERROR_TEMPLATE, SMARTY_VIEW_CACHE_DISABLED );
> +			$this->addHeaderResponse( "HTTP/1.0 404" );
>  
>              $this->_message = $message;
>          }
> 
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://limedaley.com/pipermail/plog-svn/attachments/20110301/d785b273/attachment.pgp>


More information about the pLog-svn mailing list