[pLog-svn] r6088 - plog/branches/lifetype-1.2/class/security

Mark Wu markplace at gmail.com
Thu Nov 29 11:56:49 EST 2007

Hi Jon:

I still don't think run all filters twice is right.
Even you add a secondRun there, to make sure the addComment only add once.
It also increas the system burden, it is really bad for a big site. :(

> > Why pual add this is becasue he want to the ip-block or or 
> > dns-anti-spam can record the ip of the comments, too....
>  	Ah, that's right.  But, it is also useful for the 
> plugins to interact with each other's output too.

That's why we just run them once is enough, not run them twice and use a
"secondRun" flag to control it.

>  	Probably sidetracking the conversation, but we had once 
> talked about letting each plugin decide whether the comment 
> should be saved in the database or not.  That way, the 
> programmer (or the user) for each plugin can decide whether 
> it should be saved.
>  	Maybe people want to have auth image failures saved in 
> the database, sort of as a moderation type feature, for those 
> users who can't figure out how to get the right code.  Or be 
> able to have stricter hostblock rules, but they get saved in 
> the database and the blog owner could delete them or publish 
> them as appropriate.

Then, developer should consider use "event/notification" model, not pipeline

I will insist my change of rev. 6089.


More information about the pLog-svn mailing list