[pLog-svn] dynamic plugins

Ahmad Saleh ahmadfds at gmail.com
Tue Jun 12 12:20:08 EDT 2007 

and what about second attached file?
I think it's work in 1.2
but the problem as what jon say ({php}{/php}) smarty tags.

On 6/12/07, Oscar Renalias <oscar at renalias.net> wrote:
>
> It looks good to me, I guess.
>
> The only problem I see is that unfortunately, this cannot be
> implemented before 1.3. Doing it now would "break" the plugin API,
> which is something we don't want to do in minor releases (like 1.2.2,
> 1.2.3, etc) The idea is that a plugin developed for 1.2 should work
> in 1.2.3, 1.2.6 and 1.2.17 and by introducing this in 1.2.4, we would
> be breaking our own rules.
>
> If that's ok with you, I guess we can go ahead and merge these
> changes in 1.3.
>
> Oscar
>
> On 12 Jun 2007, at 17:27, Jon Daley wrote:
>
> >       Let's let the others see your core changes.  I don't see them as
> > hurting anything to add them into the core.  We could add a
> > configuration
> > option even to make it not affect anyone, but probably the
> > configuration
> > option might not be understood.  I think the "else" case in blogview
> > shouldn't take very long to get the empty set of dynamic plugins, if
> > people aren't using a dynamic plugin?
> >
> >
> >   On Tue, 12 Jun 2007, Ahmad Saleh wrote:
> >
> >> So what you suggest?
> >>
> >>
> >> On 6/12/07, Jon Daley <plogworld at jon.limedaley.com> wrote:
> >>>
> >>>         Using {php} in the templates isn't that great - blog
> >>> hosters won't
> >>> want to use it.
> >>>
> >>> On Tue, 12 Jun 2007, Ahmad Saleh wrote:
> >>>
> >>>> I found a solution without changing any core file.
> >>>>
> >>>> Regards,
> >>>>   Ahmad
> >>>>
> >>>> On 6/12/07, Ahmad Saleh <ahmadfds at gmail.com> wrote:
> >>>>>
> >>>>> See the attached file
> >>>>>
> >>>>> Regards,
> >>>>>    Ahmad
> >>>>>
> >>>>> On 6/12/07, Mark Wu <markplace at gmail.com> wrote:
> >>>>>>
> >>>>>>  Hi Ahmad:
> >>>>>>
> >>>>>> Maybe you can send to this mailing list first. Then we can have a
> >>> detail
> >>>>>> look at it and discuss with you  about how to integrate( or
> >>>>>> not to
> >>>>>> integrate) those files to the core.
> >>>>>>
> >>>>>> Or we have no idea the change is reasonable or not.
> >>>>>>
> >>>>>> Mark
> >>>>>>
> >>>>>>  ------------------------------
> >>>>>> *From:* plog-svn-bounces at devel.lifetype.net [mailto:
> >>>>>> plog-svn-bounces at devel.lifetype.net] *On Behalf Of *Ahmad Saleh
> >>>>>> *Sent:* Tuesday, June 12, 2007 6:47 PM
> >>>>>> *To:* plog-svn at devel.lifetype.net
> >>>>>> *Subject:* Re: [pLog-svn] dynamic plugins
> >>>>>>
> >>>>>> the problem here that this plugin object must send in each
> >>>>>> request,
> >>> but
> >>>>>> if this template is cached then it will not be send.
> >>>>>>
> >>>>>>
> >>>>>> On 6/12/07, Oscar Renalias <oscar at renalias.net> wrote:
> >>>>>>>
> >>>>>>> I think that providing plugins that change core files is not
> >>>>>>> a good
> >>>>>>> idea, we're unfortunately not going to support a bunch of people
> >>>>>>> running around with core code changes.
> >>>>>>>
> >>>>>>> Was there really no other way to implement this, than to modify
> >>> core
> >>>>>>> code?
> >>>>>>>
> >>>>>>> On 6/12/07, Ahmad Saleh < ahmadfds at gmail.com> wrote:
> >>>>>>>> I have finished Crystal Poll plugin but if any one want to
> >>>>>>>> use it
> >>>>>>>> he must make above changes which we talked about, so that I
> >>> include
> >>>>>>> this 3
> >>>>>>>> files in (core files) folder . is that acceptance for you?
> >>>>>>>>
> >>>>>>>> Regards,
> >>>>>>>>      Ahmad
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On 6/5/07, Ahmad Saleh <ahmadfds at gmail.com > wrote:
> >>>>>>>>> another thing,
> >>>>>>>>> I made test plugin that have getTest function which rerturn
> >>> random
> >>>>>>> number
> >>>>>>>>> isDynamic field of this plugin have true value
> >>>>>>>>> then I call it in footer.template like this:
> >>>>>>>>>
> >>>>>>>>> { dynamic}
> >>>>>>>>> {$test->getTest()}
> >>>>>>>>> {/dynamic}
> >>>>>>>>>
> >>>>>>>>> and it's worked without any problem.
> >>>>>>>>>
> >>>>>>>>> Regards,
> >>>>>>>>>     Ahmad
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On 6/4/07, Oscar Renalias < oscar at renalias.net> wrote:
> >>>>>>>>>
> >>>>>>>>>> Well this sounds like a reasonable approach... but I see at
> >>>>>>> least one
> >>>>>>>> problem.
> >>>>>>>>>>
> >>>>>>>>>> When a page is cached, currently its data is not loaded. So
> >>> for
> >>>>>>>>>> example $posts and $blog are not available in
> >>> main.templatewhen
> >>>>>>> it's
> >>>>>>>>>> cached because it doesn't make any sense to load that data
> >>>>>>> anymore. So
> >>>>>>>>>> if you develop a plugin that registers itself as dynamic and
> >>>>>>> depends
> >>>>>>>>>> in any of the data that is not available anymore, this won't
> >>>>>>> work. The
> >>>>>>>>>> plugin will be there and trying to run, but it's data will
> >>> not.
> >>>>>>>>>>
> >>>>>>>>>> But before we dig deeper into this, can anybody list any
> >>>>>>> examples of
> >>>>>>>>>> plugins that would *really* benefit of running even in cached
> >>>>>>> pages
> >>>>>>>>>> (other than a plugin that would list the number of users
> >>>>>>> currently
> >>>>>>>>>> logged in)
> >>>>>>>>>>
> >>>>>>>>>> Oscar
> >>>>>>>>>>
> >>>>>>>>>> On 6/3/07, Ahmad Saleh <ahmadfds at gmail.com> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> 1) Add ($isDynamic = false) field in PluginBase class.
> >>>>>>>>>>>> 2) just add function (getDynamicPlugins()) that return
> >>> only
> >>>>>>> dynamic
> >>>>>>>>>>> plugins
> >>>>>>>>>>> without changing any thing in getPlugins() function.
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> 3) in BlogView class:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> sorry about this mistake :)
> >>>>>>>>>>>
> >>>>>>>>>>> Regards,
> >>>>>>>>>>>    Ahmad
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> _______________________________________________
> >>>>>>>>>>> pLog-svn mailing list
> >>>>>>>>>>> pLog-svn at devel.lifetype.net
> >>>>>>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>>>>>>>>>
> >>>>>>>>>> _______________________________________________
> >>>>>>>>>> pLog-svn mailing list
> >>>>>>>>>> pLog-svn at devel.lifetype.net
> >>>>>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> _______________________________________________
> >>>>>>>> pLog-svn mailing list
> >>>>>>>> pLog-svn at devel.lifetype.net
> >>>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>>>>>>
> >>>>>>> _______________________________________________
> >>>>>>> pLog-svn mailing list
> >>>>>>> pLog-svn at devel.lifetype.net
> >>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> pLog-svn mailing list
> >>>>>> pLog-svn at devel.lifetype.net
> >>>>>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>
> >>> --
> >>> Jon Daley
> >>> http://jon.limedaley.com/
> >>>
> >>> God humbled himself; that's a good place for us to start too.
> >>> -- Dave Harvey
> >>> _______________________________________________
> >>> pLog-svn mailing list
> >>> pLog-svn at devel.lifetype.net
> >>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>
> >>
> >
> > --
> > Jon Daley
> > http://jon.limedaley.com/
> >
> > Hair: The only thing that will really prevent baldness.
> > -- Drew Berkowitz
> > _______________________________________________
> > pLog-svn mailing list
> > pLog-svn at devel.lifetype.net
> > http://limedaley.com/mailman/listinfo/plog-svn
> >
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://limedaley.com/pipermail/plog-svn/attachments/20070612/42e10995/attachment-0001.htm

More information about the pLog-svn mailing list