and what about second attached file?<br>I think it's work in 1.2<br>but the problem as what jon say ({php}{/php}) smarty tags.<br><br><div><span class="gmail_quote">On 6/12/07, <b class="gmail_sendername">Oscar Renalias
</b> <<a href="mailto:oscar@renalias.net">oscar@renalias.net</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">It looks good to me, I guess.
<br><br>The only problem I see is that unfortunately, this cannot be<br>implemented before 1.3. Doing it now would "break" the plugin API,<br>which is something we don't want to do in minor releases (like 1.2.2
,<br>1.2.3, etc) The idea is that a plugin developed for 1.2 should work<br>in 1.2.3, 1.2.6 and 1.2.17 and by introducing this in 1.2.4, we would<br>be breaking our own rules.<br><br>If that's ok with you, I guess we can go ahead and merge these
<br>changes in 1.3.<br><br>Oscar<br><br>On 12 Jun 2007, at 17:27, Jon Daley wrote:<br><br>> Let's let the others see your core changes. I don't see them as<br>> hurting anything to add them into the core. We could add a
<br>> configuration<br>> option even to make it not affect anyone, but probably the<br>> configuration<br>> option might not be understood. I think the "else" case in blogview<br>> shouldn't take very long to get the empty set of dynamic plugins, if
<br>> people aren't using a dynamic plugin?<br>><br>><br>> On Tue, 12 Jun 2007, Ahmad Saleh wrote:<br>><br>>> So what you suggest?<br>>><br>>><br>>> On 6/12/07, Jon Daley <<a href="mailto:plogworld@jon.limedaley.com">
plogworld@jon.limedaley.com</a>> wrote:<br>>>><br>>>> Using {php} in the templates isn't that great - blog<br>>>> hosters won't<br>>>> want to use it.<br>>>>
<br>>>> On Tue, 12 Jun 2007, Ahmad Saleh wrote:<br>>>><br>>>>> I found a solution without changing any core file.<br>>>>><br>>>>> Regards,<br>>>>> Ahmad<br>
>>>><br>>>>> On 6/12/07, Ahmad Saleh <<a href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</a>> wrote:<br>>>>>><br>>>>>> See the attached file<br>>>>>>
<br>>>>>> Regards,<br>>>>>> Ahmad<br>>>>>><br>>>>>> On 6/12/07, Mark Wu <<a href="mailto:markplace@gmail.com">markplace@gmail.com</a>> wrote:<br>>>>>>>
<br>>>>>>> Hi Ahmad:<br>>>>>>><br>>>>>>> Maybe you can send to this mailing list first. Then we can have a<br>>>> detail<br>>>>>>> look at it and discuss with you about how to integrate( or
<br>>>>>>> not to<br>>>>>>> integrate) those files to the core.<br>>>>>>><br>>>>>>> Or we have no idea the change is reasonable or not.<br>>>>>>>
<br>>>>>>> Mark<br>>>>>>><br>>>>>>> ------------------------------<br>>>>>>> *From:* <a href="mailto:plog-svn-bounces@devel.lifetype.net">plog-svn-bounces@devel.lifetype.net
</a> [mailto:<br>>>>>>> <a href="mailto:plog-svn-bounces@devel.lifetype.net">plog-svn-bounces@devel.lifetype.net</a>] *On Behalf Of *Ahmad Saleh<br>>>>>>> *Sent:* Tuesday, June 12, 2007 6:47 PM
<br>>>>>>> *To:* <a href="mailto:plog-svn@devel.lifetype.net">plog-svn@devel.lifetype.net</a><br>>>>>>> *Subject:* Re: [pLog-svn] dynamic plugins<br>>>>>>><br>>>>>>> the problem here that this plugin object must send in each
<br>>>>>>> request,<br>>>> but<br>>>>>>> if this template is cached then it will not be send.<br>>>>>>><br>>>>>>><br>>>>>>> On 6/12/07, Oscar Renalias <
<a href="mailto:oscar@renalias.net">oscar@renalias.net</a>> wrote:<br>>>>>>>><br>>>>>>>> I think that providing plugins that change core files is not<br>>>>>>>> a good
<br>>>>>>>> idea, we're unfortunately not going to support a bunch of people<br>>>>>>>> running around with core code changes.<br>>>>>>>><br>>>>>>>> Was there really no other way to implement this, than to modify
<br>>>> core<br>>>>>>>> code?<br>>>>>>>><br>>>>>>>> On 6/12/07, Ahmad Saleh < <a href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</a>> wrote:
<br>>>>>>>>> I have finished Crystal Poll plugin but if any one want to<br>>>>>>>>> use it<br>>>>>>>>> he must make above changes which we talked about, so that I
<br>>>> include<br>>>>>>>> this 3<br>>>>>>>>> files in (core files) folder . is that acceptance for you?<br>>>>>>>>><br>>>>>>>>> Regards,
<br>>>>>>>>> Ahmad<br>>>>>>>>><br>>>>>>>>><br>>>>>>>>> On 6/5/07, Ahmad Saleh <<a href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com
</a> > wrote:<br>>>>>>>>>> another thing,<br>>>>>>>>>> I made test plugin that have getTest function which rerturn<br>>>> random<br>>>>>>>> number
<br>>>>>>>>>> isDynamic field of this plugin have true value<br>>>>>>>>>> then I call it in footer.template like this:<br>>>>>>>>>><br>>>>>>>>>> { dynamic}
<br>>>>>>>>>> {$test->getTest()}<br>>>>>>>>>> {/dynamic}<br>>>>>>>>>><br>>>>>>>>>> and it's worked without any problem.
<br>>>>>>>>>><br>>>>>>>>>> Regards,<br>>>>>>>>>> Ahmad<br>>>>>>>>>><br>>>>>>>>>><br>
>>>>>>>>> On 6/4/07, Oscar Renalias < <a href="mailto:oscar@renalias.net">oscar@renalias.net</a>> wrote:<br>>>>>>>>>><br>>>>>>>>>>> Well this sounds like a reasonable approach... but I see at
<br>>>>>>>> least one<br>>>>>>>>> problem.<br>>>>>>>>>>><br>>>>>>>>>>> When a page is cached, currently its data is not loaded. So
<br>>>> for<br>>>>>>>>>>> example $posts and $blog are not available in<br>>>> main.templatewhen<br>>>>>>>> it's<br>>>>>>>>>>> cached because it doesn't make any sense to load that data
<br>>>>>>>> anymore. So<br>>>>>>>>>>> if you develop a plugin that registers itself as dynamic and<br>>>>>>>> depends<br>>>>>>>>>>> in any of the data that is not available anymore, this won't
<br>>>>>>>> work. The<br>>>>>>>>>>> plugin will be there and trying to run, but it's data will<br>>>> not.<br>>>>>>>>>>><br>>>>>>>>>>> But before we dig deeper into this, can anybody list any
<br>>>>>>>> examples of<br>>>>>>>>>>> plugins that would *really* benefit of running even in cached<br>>>>>>>> pages<br>>>>>>>>>>> (other than a plugin that would list the number of users
<br>>>>>>>> currently<br>>>>>>>>>>> logged in)<br>>>>>>>>>>><br>>>>>>>>>>> Oscar<br>>>>>>>>>>>
<br>>>>>>>>>>> On 6/3/07, Ahmad Saleh <<a href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</a>> wrote:<br>>>>>>>>>>>><br>>>>>>>>>>>>>
<br>>>>>>>>>>>>><br>>>>>>>>>>>>><br>>>>>>>>>>>>> 1) Add ($isDynamic = false) field in PluginBase class.<br>>>>>>>>>>>>> 2) just add function (getDynamicPlugins()) that return
<br>>>> only<br>>>>>>>> dynamic<br>>>>>>>>>>>> plugins<br>>>>>>>>>>>> without changing any thing in getPlugins() function.<br>
>>>>>>>>>>><br>>>>>>>>>>>><br>>>>>>>>>>>>><br>>>>>>>>>>>>><br>>>>>>>>>>>>> 3) in BlogView class:
<br>>>>>>>>>>>><br>>>>>>>>>>>><br>>>>>>>>>>>> sorry about this mistake :)<br>>>>>>>>>>>><br>
>>>>>>>>>>> Regards,<br>>>>>>>>>>>> Ahmad<br>>>>>>>>>>>><br>>>>>>>>>>>><br>>>>>>>>>>>> _______________________________________________
<br>>>>>>>>>>>> pLog-svn mailing list<br>>>>>>>>>>>> <a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br>>>>>>>>>>>>
<a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>>>>>>>>>>>><br>>>>>>>>>>> _______________________________________________
<br>>>>>>>>>>> pLog-svn mailing list<br>>>>>>>>>>> <a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br>>>>>>>>>>>
<a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>>>>>>>>>>><br>>>>>>>>>><br>>>>>>>>>>
<br>>>>>>>>><br>>>>>>>>><br>>>>>>>>> _______________________________________________<br>>>>>>>>> pLog-svn mailing list<br>>>>>>>>>
<a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br>>>>>>>>> <a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>
>>>>>>>><br>>>>>>>> _______________________________________________<br>>>>>>>> pLog-svn mailing list<br>>>>>>>> <a href="mailto:pLog-svn@devel.lifetype.net">
pLog-svn@devel.lifetype.net</a><br>>>>>>>> <a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>>>>>>>><br>>>>>>>
<br>>>>>>><br>>>>>>> _______________________________________________<br>>>>>>> pLog-svn mailing list<br>>>>>>> <a href="mailto:pLog-svn@devel.lifetype.net">
pLog-svn@devel.lifetype.net</a><br>>>>>>> <a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>>>>>>><br>>>>>><br>
>>>>><br>>>>>><br>>>>><br>>>><br>>>> --<br>>>> Jon Daley<br>>>> <a href="http://jon.limedaley.com/">http://jon.limedaley.com/</a><br>>>>
<br>>>> God humbled himself; that's a good place for us to start too.<br>>>> -- Dave Harvey<br>>>> _______________________________________________<br>>>> pLog-svn mailing list<br>>>>
<a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br>>>> <a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</a><br>>>><br>>>
<br>><br>> --<br>> Jon Daley<br>> <a href="http://jon.limedaley.com/">http://jon.limedaley.com/</a><br>><br>> Hair: The only thing that will really prevent baldness.<br>> -- Drew Berkowitz<br>> _______________________________________________
<br>> pLog-svn mailing list<br>> <a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br>> <a href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn
</a><br>><br><br>_______________________________________________<br>pLog-svn mailing list<br><a href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</a><br><a href="http://limedaley.com/mailman/listinfo/plog-svn">
http://limedaley.com/mailman/listinfo/plog-svn</a><br></blockquote></div><br>