[pLog-svn] r5324 - plog/branches/lifetype-1.2/class/action

Oscar Renalias oscar at renalias.net
Sat Apr 21 07:55:26 EDT 2007


On 21 Apr 2007, at 11:57, Jon Daley wrote:

>  	Duh.  I took out the dynamic part when testing after your change.
> It looks good on the devel blog and mine. Sorry about that.
>
>  	By the way, it seems relatively hard to make someone an admin,
> from the database side - ie. what does "site_admin" do?  It doesn't  
> appear
> to do anything.  I had to add all the additional rows for each  
> permission
> in order to promote my user to an admin (so I could check what  
> settings
> you were using for template_cache, etc)

I need to check that, I don't remember what site_admin does right now.

>
>  	Also, I wonder if our double-running wizard problem could be
> solved by removing the id column from the users_permissions table.
> Similar to how we used to get duplicates in the config table.  My  
> guess is
> that we don't use the id column, and the database will then enforce no
> duplicate entries, so the wizard could complete properly.  Should I  
> make
> that change?
>  	We would have to do a similar thing as we did in the config table,
> but since this is more critical if it stays wrong, I'll probably do  
> it in
> a safer way - the config table way had trouble with different  
> versions of
> mysql, and some people commented it out because it didn't work on  
> their
> blog.
>  	If I grab all of the results in php, and then erase duplicates,
> that will be cross platform capatible.  The only potential problem  
> is if
> there are so many rows that php runs out of memory.

I think that what we should do is show an error message in case users  
attempt to run wizard.php more than once, rather than making  
subsequent runs after the first one harmless. It might even be easier  
too...

Oscar


More information about the pLog-svn mailing list