[pLog-svn] r4361 - in plog/trunk: class/action class/action/admin
templates/admin templates/standard
Oscar Renalias
oscar at renalias.net
Tue Nov 28 21:52:37 GMT 2006
The problem is that I had to add some more logic to that file, since
I've implemented support for auto-detecting the currently logged in
user (the "username" field appears filled in automatically with the
user's username) and I'm afraid people will break it if they mess
around with this file.
The version of commentform.template was taken from the most current
version of the 'standard' template so it should be fully localized.
Changing the order of the fields is going to be a problem, but it can
always be done so that the template is copied to the user's template
and instead of {include file="$misctemplatepath/
commentform.template"} you've got {include file="$blogtemplate/
commentform.template"}
It also makes it a lot easier for us to maintain at least this part
of the templates if we do it this way. But of course we could just
get rid of the extra template sets altogether. They're a pain to
maintain (nobody is helping us to maintain them) and it usually is a
waste of time to update them for every major release.
Perhaps as a project we should concentrate on developing the core and
leave it up to other people to maintain templates and plugins.
On 28 Nov 2006, at 23:39, Reto Hugi wrote:
> On 28.11.2006 21:40, oscar at devel.lifetype.net wrote:
>
>> moved commentform.template to the templates/misc/ folder so that all
>> templates can use the same. This means that now to activate things
>> like
>> the 'authimage' plugin only one template needs to be modified.
>> This is
>> not something that couldn't be done right now with LT 1.1.
>
> I'm not sure this is a good design idea (design as in "application
> design").
> With some more plugins and a short template structure comparison we
> could probably easily argue, that all template files should go to /
> misc/
> because all design happens on css level...
>
> but some might want the form elements in commentform.template sorted
> differently, right? shouldn't this be something a blog hoster has
> to do
> manually if he want's it like that? after all this is just a pain for
> all single users. I'm sure we will get plenty of questions, why the
> changes in the whatevertemplate/commentform.template don't show up in
> the browser at all...
>
> what about template editor? users aren't able to edit their
> comment.template anymore this way (on a per blog basis, not for
> admins...)
>
> what about i18n?
>
> oh well, maybe you have very good arguments, too... ;)
>
> reto
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>
More information about the pLog-svn
mailing list