<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.6000.16640" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=217462307-02062008><FONT face=新細明體
color=#0000ff size=2>The username in comment is not the the username in $user
...</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=217462307-02062008><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=217462307-02062008><FONT face=新細明體
color=#0000ff size=2>I think we should not use the usernamevalidator
here.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=217462307-02062008><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=217462307-02062008><FONT face=新細明體
color=#0000ff size=2> Mark</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=zh-tw dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> plog-svn-bounces@devel.lifetype.net
[mailto:plog-svn-bounces@devel.lifetype.net] <B>On Behalf Of </B>Paul
Westbrook<BR><B>Sent:</B> Monday, June 02, 2008 3:21 PM<BR><B>To:</B> LifeType
Developer List<BR><B>Subject:</B> Re: [pLog-svn] r6479 -
plog/branches/lifetype-1.2/class/action<BR></FONT><BR></DIV>
<DIV></DIV>Hello,<BR> There is a problem with this change.
Some templates use the "userName" field for the commentor's name. So if
I enter my first and last name (with a space in between) the comment will not
be committed.<BR><BR>--Paul<BR><BR>
<DIV class=gmail_quote>On Sat, May 24, 2008 at 12:19 PM, <<A
href="mailto:jondaley@devel.lifetype.net"
target=_blank>jondaley@devel.lifetype.net</A>> wrote:<BR>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0pt 0pt 0pt 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">Author:
jondaley<BR>Date: 2008-05-24 15:19:11 -0400 (Sat, 24 May 2008)<BR>New
Revision: 6479<BR><BR>Modified:<BR>
plog/branches/lifetype-1.2/class/action/addcommentaction.class.php<BR>Log:<BR>removed
old variable. use username validator for usernames. allow html
in comment text. The xhtmlize filter will remove bad stuff for us?
Need to verify<BR><BR>Modified:
plog/branches/lifetype-1.2/class/action/addcommentaction.class.php<BR>===================================================================<BR>---
plog/branches/lifetype-1.2/class/action/addcommentaction.class.php
2008-05-24 19:18:22 UTC (rev 6478)<BR>+++
plog/branches/lifetype-1.2/class/action/addcommentaction.class.php
2008-05-24 19:19:11 UTC (rev 6479)<BR>@@ -30,7 +30,6 @@<BR><BR>
var $_articleId;<BR> var
$_blogId;<BR>- var $_opId;<BR>
var $_userName;<BR> var
$_userEmail;<BR> var $_userUrl;<BR>@@ -70,9 +69,9
@@<BR>
$this->_form->setFieldErrorMessage( "parentId",
$this->_locale->tr("error_incorrect_article_id" ));<BR>
$this->registerFieldValidator( "userEmail", new EmailValidator(),
true );<BR>
$this->_form->setFieldErrorMessage( "userEmail",
$this->_locale->tr("error_incorrect_email_address" ));<BR>-
$this->registerFieldValidator( "userName", new StringValidator());<BR>+
$this->registerFieldValidator( "userName", new
UsernameValidator());<BR>
$this->_form->setFieldErrorMessage(
"userName", $this->_locale->tr("error_comment_without_name" ));<BR>-
$this->registerFieldValidator( "commentText", new
StringValidator());<BR>+
$this->registerFieldValidator( "commentText",
new StringValidator( true ));<BR>
$this->_form->setFieldErrorMessage( "commentText",
$this->_locale->tr("error_comment_without_text"));<BR>
$this->registerFieldValidator( "userUrl", new HttpUrlValidator(),
true );<BR>
$this->_form->setFieldErrorMessage( "userUrl",
$this->_locale->tr("invalid_url" ));<BR>@@ -91,7 +90,6
@@<BR><BR> $this->_articleId =
$this->_request->getValue( "articleId" );<BR>
$this->_blogId =
$this->_request->getValue( "blogId" );<BR>-
$this->_opId =
$this->_request->getValue( "op" );<BR>
$this->_parentId = $this->_request->getValue(
"parentId" );<BR> if(
$this->_parentId == null || $this->_parentId == "" )<BR>
$this->_parentId =
0;<BR><BR>_______________________________________________<BR>pLog-svn
mailing list<BR><A href="mailto:pLog-svn@devel.lifetype.net"
target=_blank>pLog-svn@devel.lifetype.net</A><BR><A
href="http://limedaley.com/mailman/listinfo/plog-svn"
target=_blank>http://limedaley.com/mailman/listinfo/plog-svn</A><BR></BLOCKQUOTE></DIV><BR></BLOCKQUOTE></BODY></HTML>