<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.3086" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2>Hi Ahmad:</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2>After look at your code, I think I prefer the way 1 , and
it should add into the core without any problem. I agree Oscar's idea,
merging to 1.3 trunk is a better choice.</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2>Hi Oscar:</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2>Why this patch break the current plugin API? It seems works
with current 1.2.x plugin very well . Did I miss
something?</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2>Mark</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=231544117-12062007></SPAN><SPAN
class=231544117-12062007></SPAN><SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2></FONT></SPAN> </DIV><BR>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=zh-tw dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> plog-svn-bounces@devel.lifetype.net
[mailto:plog-svn-bounces@devel.lifetype.net] <B>On Behalf Of </B>Ahmad
Saleh<BR><B>Sent:</B> Wednesday, June 13, 2007 12:20 AM<BR><B>To:</B>
plog-svn@devel.lifetype.net<BR><B>Subject:</B> Re: [pLog-svn] dynamic
plugins<BR></FONT><BR></DIV>
<DIV></DIV>and what about second attached file?<BR>I think it's work in
1.2<BR>but the problem as what jon say ({php}{/php}) smarty tags.<BR><BR>
<DIV><SPAN class=gmail_quote>On 6/12/07, <B class=gmail_sendername>Oscar
Renalias </B><<A
href="mailto:oscar@renalias.net">oscar@renalias.net</A>> wrote:</SPAN>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0pt 0pt 0pt 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">It
looks good to me, I guess. <BR><BR>The only problem I see is that
unfortunately, this cannot be<BR>implemented before 1.3. Doing it now would
"break" the plugin API,<BR>which is something we don't want to do in minor
releases (like 1.2.2 ,<BR>1.2.3, etc) The idea is that a plugin developed
for 1.2 should work<BR>in 1.2.3, 1.2.6 and 1.2.17 and by introducing this in
1.2.4, we would<BR>be breaking our own rules.<BR><BR>If that's ok with you,
I guess we can go ahead and merge these <BR>changes in
1.3.<BR><BR>Oscar<SPAN class=231544117-12062007><FONT face=新細明體
color=#0000ff size=2> </FONT></SPAN><BR><BR>On 12 Jun 2007, at
17:27, Jon Daley wrote:<BR><BR>>
Let's let the others see your core changes. I don't see them
as<BR>> hurting anything to add them into the core. We could
add a <BR>> configuration<BR>> option even to make it not affect
anyone, but probably the<BR>> configuration<BR>> option might not be
understood. I think the "else" case in blogview<BR>> shouldn't
take very long to get the empty set of dynamic plugins, if <BR>> people
aren't using a dynamic plugin?<BR>><BR>><BR>> On Tue,
12 Jun 2007, Ahmad Saleh wrote:<BR>><BR>>> So what you
suggest?<BR>>><BR>>><BR>>> On 6/12/07, Jon Daley <<A
href="mailto:plogworld@jon.limedaley.com">
plogworld@jon.limedaley.com</A>>
wrote:<BR>>>><BR>>>>
Using {php} in the templates isn't that great - blog<BR>>>> hosters
won't<BR>>>> want to use it.<BR>>>> <BR>>>> On
Tue, 12 Jun 2007, Ahmad Saleh wrote:<BR>>>><BR>>>>> I
found a solution without changing any core
file.<BR>>>>><BR>>>>>
Regards,<BR>>>>>
Ahmad<BR>>>>><BR>>>>> On 6/12/07, Ahmad Saleh <<A
href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</A>>
wrote:<BR>>>>>><BR>>>>>> See the attached
file<BR>>>>>> <BR>>>>>>
Regards,<BR>>>>>> Ahmad<BR>>>>>><BR>>>>>>
On 6/12/07, Mark Wu <<A
href="mailto:markplace@gmail.com">markplace@gmail.com</A>>
wrote:<BR>>>>>>>
<BR>>>>>>> Hi
Ahmad:<BR>>>>>>><BR>>>>>>> Maybe you can
send to this mailing list first. Then we can have a<BR>>>>
detail<BR>>>>>>> look at it and discuss with
you about how to integrate( or <BR>>>>>>> not
to<BR>>>>>>> integrate) those files to the
core.<BR>>>>>>><BR>>>>>>> Or we have no
idea the change is reasonable or not.<BR>>>>>>>
<BR>>>>>>>
Mark<BR>>>>>>><BR>>>>>>> ------------------------------<BR>>>>>>>
*From:* <A
href="mailto:plog-svn-bounces@devel.lifetype.net">plog-svn-bounces@devel.lifetype.net
</A>[mailto:<BR>>>>>>> <A
href="mailto:plog-svn-bounces@devel.lifetype.net">plog-svn-bounces@devel.lifetype.net</A>]
*On Behalf Of *Ahmad Saleh<BR>>>>>>> *Sent:* Tuesday, June
12, 2007 6:47 PM <BR>>>>>>> *To:* <A
href="mailto:plog-svn@devel.lifetype.net">plog-svn@devel.lifetype.net</A><BR>>>>>>>
*Subject:* Re: [pLog-svn] dynamic
plugins<BR>>>>>>><BR>>>>>>> the problem
here that this plugin object must send in each <BR>>>>>>>
request,<BR>>>> but<BR>>>>>>> if this template is
cached then it will not be
send.<BR>>>>>>><BR>>>>>>><BR>>>>>>>
On 6/12/07, Oscar Renalias < <A
href="mailto:oscar@renalias.net">oscar@renalias.net</A>>
wrote:<BR>>>>>>>><BR>>>>>>>> I
think that providing plugins that change core files is
not<BR>>>>>>>> a good <BR>>>>>>>>
idea, we're unfortunately not going to support a bunch of
people<BR>>>>>>>> running around with core code
changes.<BR>>>>>>>><BR>>>>>>>> Was
there really no other way to implement this, than to modify <BR>>>>
core<BR>>>>>>>>
code?<BR>>>>>>>><BR>>>>>>>> On
6/12/07, Ahmad Saleh < <A
href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</A>> wrote:
<BR>>>>>>>>> I have finished Crystal Poll plugin but
if any one want to<BR>>>>>>>>> use
it<BR>>>>>>>>> he must make above changes which we
talked about, so that I <BR>>>>
include<BR>>>>>>>> this
3<BR>>>>>>>>> files in (core files) folder . is that
acceptance for
you?<BR>>>>>>>>><BR>>>>>>>>>
Regards,
<BR>>>>>>>>> Ahmad<BR>>>>>>>>><BR>>>>>>>>><BR>>>>>>>>>
On 6/5/07, Ahmad Saleh <<A
href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com </A>>
wrote:<BR>>>>>>>>>> another
thing,<BR>>>>>>>>>> I made test plugin that have
getTest function which rerturn<BR>>>>
random<BR>>>>>>>> number
<BR>>>>>>>>>> isDynamic field of this plugin have
true value<BR>>>>>>>>>> then I call it in
footer.template like
this:<BR>>>>>>>>>><BR>>>>>>>>>>
{ dynamic} <BR>>>>>>>>>>
{$test->getTest()}<BR>>>>>>>>>>
{/dynamic}<BR>>>>>>>>>><BR>>>>>>>>>>
and it's worked without any problem.
<BR>>>>>>>>>><BR>>>>>>>>>>
Regards,<BR>>>>>>>>>>
Ahmad<BR>>>>>>>>>><BR>>>>>>>>>><BR>>>>>>>>>>
On 6/4/07, Oscar Renalias < <A
href="mailto:oscar@renalias.net">oscar@renalias.net</A>>
wrote:<BR>>>>>>>>>><BR>>>>>>>>>>>
Well this sounds like a reasonable approach... but I see at
<BR>>>>>>>> least
one<BR>>>>>>>>>
problem.<BR>>>>>>>>>>><BR>>>>>>>>>>>
When a page is cached, currently its data is not loaded. So <BR>>>>
for<BR>>>>>>>>>>> example $posts and $blog are
not available in<BR>>>>
main.templatewhen<BR>>>>>>>>
it's<BR>>>>>>>>>>> cached because it doesn't
make any sense to load that data <BR>>>>>>>> anymore.
So<BR>>>>>>>>>>> if you develop a plugin that
registers itself as dynamic and<BR>>>>>>>>
depends<BR>>>>>>>>>>> in any of the data that
is not available anymore, this won't <BR>>>>>>>> work.
The<BR>>>>>>>>>>> plugin will be there and
trying to run, but it's data will<BR>>>>
not.<BR>>>>>>>>>>><BR>>>>>>>>>>>
But before we dig deeper into this, can anybody list any
<BR>>>>>>>> examples
of<BR>>>>>>>>>>> plugins that would *really*
benefit of running even in cached<BR>>>>>>>>
pages<BR>>>>>>>>>>> (other than a plugin that
would list the number of users <BR>>>>>>>>
currently<BR>>>>>>>>>>> logged
in)<BR>>>>>>>>>>><BR>>>>>>>>>>>
Oscar<BR>>>>>>>>>>>
<BR>>>>>>>>>>> On 6/3/07, Ahmad Saleh <<A
href="mailto:ahmadfds@gmail.com">ahmadfds@gmail.com</A>>
wrote:<BR>>>>>>>>>>>><BR>>>>>>>>>>>>>
<BR>>>>>>>>>>>>><BR>>>>>>>>>>>>><BR>>>>>>>>>>>>>
1) Add ($isDynamic = false) field in PluginBase
class.<BR>>>>>>>>>>>>> 2) just add
function (getDynamicPlugins()) that return <BR>>>>
only<BR>>>>>>>>
dynamic<BR>>>>>>>>>>>>
plugins<BR>>>>>>>>>>>> without changing any
thing in getPlugins()
function.<BR>>>>>>>>>>>><BR>>>>>>>>>>>><BR>>>>>>>>>>>>><BR>>>>>>>>>>>>><BR>>>>>>>>>>>>>
3) in BlogView class:
<BR>>>>>>>>>>>><BR>>>>>>>>>>>><BR>>>>>>>>>>>>
sorry about this mistake
:)<BR>>>>>>>>>>>><BR>>>>>>>>>>>>
Regards,<BR>>>>>>>>>>>> Ahmad<BR>>>>>>>>>>>><BR>>>>>>>>>>>><BR>>>>>>>>>>>>
_______________________________________________
<BR>>>>>>>>>>>> pLog-svn mailing
list<BR>>>>>>>>>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>>>>>>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>>>>>>>>>><BR>>>>>>>>>>>
_______________________________________________
<BR>>>>>>>>>>> pLog-svn mailing
list<BR>>>>>>>>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>>>>>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>>>>>>>>><BR>>>>>>>>>><BR>>>>>>>>>>
<BR>>>>>>>>><BR>>>>>>>>><BR>>>>>>>>>
_______________________________________________<BR>>>>>>>>>
pLog-svn mailing list<BR>>>>>>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>>>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>>>>>>><BR>>>>>>>>
_______________________________________________<BR>>>>>>>>
pLog-svn mailing list<BR>>>>>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>>>>>><BR>>>>>>>
<BR>>>>>>><BR>>>>>>>
_______________________________________________<BR>>>>>>>
pLog-svn mailing list<BR>>>>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>>>>><BR>>>>>><BR>>>>>><BR>>>>>><BR>>>>><BR>>>><BR>>>>
--<BR>>>> Jon Daley<BR>>>> <A
href="http://jon.limedaley.com/">http://jon.limedaley.com/</A><BR>>>>
<BR>>>> God humbled himself; that's a good place for us to start
too.<BR>>>> -- Dave Harvey<BR>>>>
_______________________________________________<BR>>>> pLog-svn
mailing list<BR>>>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR>>>><BR>>>
<BR>><BR>> --<BR>> Jon Daley<BR>> <A
href="http://jon.limedaley.com/">http://jon.limedaley.com/</A><BR>><BR>>
Hair: The only thing that will really prevent baldness.<BR>> -- Drew
Berkowitz<BR>> _______________________________________________ <BR>>
pLog-svn mailing list<BR>> <A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR>>
<A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn
</A><BR>><BR><BR>_______________________________________________<BR>pLog-svn
mailing list<BR><A
href="mailto:pLog-svn@devel.lifetype.net">pLog-svn@devel.lifetype.net</A><BR><A
href="http://limedaley.com/mailman/listinfo/plog-svn">http://limedaley.com/mailman/listinfo/plog-svn</A><BR></BLOCKQUOTE></DIV><BR></BLOCKQUOTE></BODY></HTML>