[pLog-svn] r6859 - plog/branches/lifetype-1.2/class/action/admin

[jondaley at devel.lifetype.net]

Author: jondaley
Date: 2009-04-11 15:18:23 -0400 (Sat, 11 Apr 2009)
New Revision: 6859

Modified:
   plog/branches/lifetype-1.2/class/action/admin/adminupdateglobalsettingsaction.class.php
Log:
comment about saving random data to the database.  Isn't critical, since it is only site admins, but still kind of odd

Modified: plog/branches/lifetype-1.2/class/action/admin/adminupdateglobalsettingsaction.class.php
===================================================================
--- plog/branches/lifetype-1.2/class/action/admin/adminupdateglobalsettingsaction.class.php	2009-04-11 19:16:51 UTC (rev 6858)
+++ plog/branches/lifetype-1.2/class/action/admin/adminupdateglobalsettingsaction.class.php	2009-04-11 19:18:23 UTC (rev 6859)
@@ -108,7 +108,9 @@
             
         	// we can proceed to update the config
             foreach( $this->_newConfigOpts as $key => $value ) {
-                if(is_array($value))
+                    // TODO: we shouldn't blindly save all configuration values from the user, right?
+                    // An admin could fill up the config table with all sorts of garbage.
+                if(is_array($value) || is_object($value))
                     $this->_config->setValue($key, $value);
                 else
                     $this->_config->setValue($key, trim($value));