[pLog-svn] 1.2.9 actions?

Jon Daley plogworld at jon.limedaley.com
Fri May 16 15:24:47 EDT 2008


 	Did we decide what we are going to do?  It sounded like Mark's 
suggestions were pretty good.  Can anyone think of problems with 
implementing those three steps?

 	Mark's list is below, with some edits from me.

1. Replace all Httpvars::getRequest in actions and views with $_request

2. extend the StringValidator to StringValidator ( $allowHtml == false) 
and allow it to check the string is plain text only or html.
   Since StringValidator doesn't do anything now (except maybe do a 
non-empty check) should it be there at all?  Maybe in the interest of 
changing less, we could do what Mark says above, and then in 2.0 remove 
the stringvalidator, unless there is some actual validation that can be 
done on it?  Maybe StringValidator is currently being used where there 
really should be a new validator created?

3. extend the registerFieldValidator, allow it to escape/filter/blahblah 
the request value and save to $request if the value is invalid. Therefore, 
the value we get in smarty template is escaped/filterd/blahblah ...
 	Should it only do that if it is invalid?  Do we end up with a case 
of having to decide whether to escape it later, or will that be easy, 
since the ErrorView will show the value that is already escaped, and then 
in perform, we can decide what to do with it, and we will know that the 
value is valid but not escaped?

4. Replace registerField with registerFieldValidator in all cases
 	Is there any place where registerField should be called by itself? 
Maybe that function should be removed/deprecated?


More information about the pLog-svn mailing list