[pLog-svn] r6452 - in plog/trunk/class: . object

[Mark Wu]

If you read commits, you can see I keep fixing them. There are two ways to
fix them:

1. Use lt_include(), include_once, require_once to include them correctly.

2. Change the file or class name to make auto load work again.

I said removing  those files will make the auto load get bad performance,
does not mean "don't fix them and leave them there". 

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Saturday, May 10, 2008 2:38 AM
> To: LifeType Developer List
> Subject: Re: [pLog-svn] r6452 - in plog/trunk/class: . object
> 
>  	Ok, so you are saying that .01% of the test scripts 
> won't work, and instead of fixing them, we should leave the 
> config loader the way it was?
> 
> On Sat, 10 May 2008, Mark Wu wrote:
> 
> > I think you should read my reply carefully,
> >
> > I said "Some scripts will not work because the class name not equal 
> > file name. (I believe I fix most of them)"
> >
> > I didn't said "don't want to think about them now? "
> >
> > The problem is you remove the test scripts from class loader, so I 
> > told you my concern.
> >
> > I don't  know why it become  "don't want to think about 
> them now? " ....
> >
> >> -----Original Message-----
> >> From: plog-svn-bounces at devel.lifetype.net
> >> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> >> Sent: Saturday, May 10, 2008 2:28 AM
> >> To: LifeType Developer List
> >> Subject: Re: [pLog-svn] r6452 - in plog/trunk/class: . object
> >>
> >>  	I still don't understand your point.  You agree that 
> they have to 
> >> be fixed before release, but don't want to think about them now?  
> >> I'll add a mantis bug report, so we don't forget to fix it later.
> >>
> >> On Sat, 10 May 2008, Mark Wu wrote:
> >>
> >>>
> >>>>> Of course our current implementaton can find the class file and 
> >>>>> include it correctly, but you never know how much time it
> >> will take.
> >>>>  	But, if it fails for the tests, it will fail for real
> >> files too,
> >>>> right?  If the directory search method doesn't really work, we 
> >>>> shouldn't be using it.
> >>>
> >>> Inlcuding the script correctly and take how much time to find the 
> >>> script file is different issue.
> >>>
> >>> 1. 99.99% percent class scripts are works. We can include
> >> this class
> >>> without any problems. Some scripts will not work because 
> the class 
> >>> name not equal file name. (I believe I fix most of them)
> >>>
> >>> 2. Fot those 0.01%, even the auto load can find the
> >> scripts, it will
> >>> take a lot of  time to find this class file, because you 
> have to go 
> >>> through all directories( especially when you are in bad luck).
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> pLog-svn mailing list
> >>> pLog-svn at devel.lifetype.net
> >>> http://limedaley.com/mailman/listinfo/plog-svn
> >>>
> >>
> >> --
> >> Jon Daley
> >> http://jon.limedaley.com/
> >>
> >> The difference between genius and stupidity is that genius has its 
> >> limits.
> >> -- Anonymous
> >> _______________________________________________
> >> pLog-svn mailing list
> >> pLog-svn at devel.lifetype.net
> >> http://limedaley.com/mailman/listinfo/plog-svn
> >
> > _______________________________________________
> > pLog-svn mailing list
> > pLog-svn at devel.lifetype.net
> > http://limedaley.com/mailman/listinfo/plog-svn
> >
> 
> --
> Jon Daley
> http://jon.limedaley.com/
> 
> There are 2 rules for success:
> 1) Never tell everything you know.
> -- Roger H. Lincoln
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn