[pLog-svn] r6452 - in plog/trunk/class: . object
Jon Daley
plogworld at jon.limedaley.com
Fri May 9 14:05:17 EDT 2008
On Sat, 10 May 2008, Mark Wu wrote:
> The loader map should re-generated before we release it, it won't include
> test files in official release.
Ok, good.
>>> 2. Oscar remove "all" lt_include(), so, if you do this,
>> some test can
>>> not run well..
>> If I am reading the code correctly, it looks through
>> the map, and if it can't be found, then looks through all of
>> the directories. So, the tests should still work correctly.
>
> Well, yes .... The side effect is "bad performance" coming back again.
>
> I don't like this. I prefer use "a small memory usage" to get "better
> performance".
I don't understand. The code currently looks in the map file, and
if it isn't found, looks through the directories alphabetically. I am
saying that it shouldn't ever look through the test directories until the
very end, since real files shouldn't ever get to those directories, unless
they are not going to be found anyway.
I think the directory list should not be alphabetical, but in an
order that makes the most sense from an efficiency standpoint. I'd want
to see when that directory search code is used, and make it work as
quickly as possible, and at least that means moving the test cases to the
end. I am not sure what other changes should be done.
More information about the pLog-svn
mailing list