[pLog-svn] r6443 - plog/branches/lifetype-1.2/templates/admin

Jon Daley plogworld at jon.limedaley.com
Mon May 5 15:02:02 EDT 2008


On Mon, 5 May 2008, reto at devel.lifetype.net wrote:
> It's not obvious in the action classes that, if some validators fail and 
> the error view outputs data from the request that data never get's 
> filtered.

 	Is this because we register the validator, but then later go 
straight to the _request object?  I haven't liked that model of sort of 
double-getting the variables.  I'd rather see the constructor, or 
somewhere at the beginning get the request, validate it, and save it to a 
local variable, and then use that local variable later.
 	Then if the constructor/get/save process was interrupted due to a 
validation error or whatever, the local values wouldn't be saved at all.
 	I guess that does have the annoyance problem of if field1 doesn't 
validate, field2 and further are erased, and you'd have to retype them. 
I am not sure how to fix that.  I guess validate *all* inputs, save them 
to the local variables, and then print the error.


More information about the pLog-svn mailing list