[pLog-svn] r6237 - plog/trunk/class/action/admin

[Jon Daley]

 	But, should it not be abstract, but have the basic "return 
this->perform()" in it?

On Sun, 16 Mar 2008, Mark Wu wrote:

> We already did that in action class, it is an abstraction method, and we
> have to implement our own in each action.
>
> Mark
>
>> -----Original Message-----
>> From: plog-svn-bounces at devel.lifetype.net
>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>> Sent: Sunday, March 16, 2008 7:27 AM
>> To: LifeType Developer List
>> Subject: Re: [pLog-svn] r6237 - plog/trunk/class/action/admin
>>
>>  	I don't know anything about the 2.0 code, but I have
>> seen a number of commits like this.  Would it be appropriate
>> to have this function moved to the base class, or make a
>> subclass called adminajaxaction or something that contains
>> common code like this?
>>
>> On Sat, 15 Mar 2008, mark at devel.lifetype.net wrote:
>>
>>> Author: mark
>>> Date: 2008-03-15 07:07:27 -0400 (Sat, 15 Mar 2008) New
>> Revision: 6237
>>>
>>> Modified:
>>>   plog/trunk/class/action/admin/adminnewpermissionaction.class.php
>>> Log:
>>> Add a missing performAjax
>>>
>>> Modified:
>>> plog/trunk/class/action/admin/adminnewpermissionaction.class.php
>>> ===================================================================
>>> ---
>> plog/trunk/class/action/admin/adminnewpermissionaction.cl
>> ass.php	2008-03-15 11:04:42 UTC (rev 6236)
>>> +++
>> plog/trunk/class/action/admin/adminnewpermissionaction.cl
>> ass.php	2008-03-15 11:07:27 UTC (rev 6237)
>>> @@ -23,5 +23,10 @@
>>> 			$this->_view = new AdminTemplatedView(
>> $this->_blogInfo, "newpermission" );
>>> 			$this->setCommonData();
>>>         }
>>> +
>>> +        function performAjax()
>>> +        {
>>> +			return( $this->perform() );
>>> +        }
>>>     }
>>> ?>
>>>
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>
>>
>> --
>> Jon Daley
>> http://jon.limedaley.com/
>>
>> It's a question of whether we're going to go forward into the
>> future, or past into the back.
>> -- Dan Quayle
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://limedaley.com/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

A closed mouth gathers no foot.