[pLog-svn] r6630 - plog/branches/lifetype-1.2/class/action

jondaley at devel.lifetype.net jondaley at devel.lifetype.net
Sat Jun 21 14:55:36 EDT 2008


Author: jondaley
Date: 2008-06-21 14:55:36 -0400 (Sat, 21 Jun 2008)
New Revision: 6630

Modified:
   plog/branches/lifetype-1.2/class/action/templateaction.class.php
Log:
removed one _request access, added note about template designers need to be careful with unvalidated data.  Should we just remove the 'request' in 2.0?

Modified: plog/branches/lifetype-1.2/class/action/templateaction.class.php
===================================================================
--- plog/branches/lifetype-1.2/class/action/templateaction.class.php	2008-06-21 18:54:37 UTC (rev 6629)
+++ plog/branches/lifetype-1.2/class/action/templateaction.class.php	2008-06-21 18:55:36 UTC (rev 6630)
@@ -73,8 +73,10 @@
                 return false;
             }	        
         	// get the name of the template file and create the view
-        	$this->_view = new TemplateView( $this->_blogInfo, 
-			                                 $this->_request->getValue( "show" ));
+        	$this->_view = new TemplateView( $this->_blogInfo, $templateFile);
+                // NOTE: this passes unvalidated data to the view,
+                // need to validate it in the template if you are
+                // going to use it.
             $this->_view->setValue( "request", $this->_request );
             // add all the common information to the view
             $this->setCommonData();



More information about the pLog-svn mailing list