[pLog-svn] r6582 - plog/branches/lifetype-1.2/class/action/admin

[Mark Wu]

These registerField() shouldn't be there.

registerField() only used in addXXXAction, it will bring the value(the value
no need to validate) back to _form.

I guess Oscar just copy them from addXXXAction to editXXXAction and did not
notice these registerFields never used.

Just a guess.

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Thursday, June 19, 2008 7:53 PM
> To: LifeType Developer List
> Subject: Re: [pLog-svn] r6582 - 
> plog/branches/lifetype-1.2/class/action/admin
> 
>  	I wondered about these too.  Do you know why they were 
> included originally?
> 
> On Thu, 19 Jun 2008, mark at devel.lifetype.net wrote:
> 
> > Author: mark
> > Date: 2008-06-19 02:10:26 -0400 (Thu, 19 Jun 2008) New 
> Revision: 6582
> >
> > Modified:
> >   
> > 
> plog/branches/lifetype-1.2/class/action/admin/admineditlinkaction.clas
> > s.php
> > Log:
> > We don't need the use registerField here, the filtered 
> input value will carry by _form itself.
> >
> > Modified: 
> > 
> plog/branches/lifetype-1.2/class/action/admin/admineditlinkaction.clas
> > s.php 
> > ===================================================================
> > --- 
> plog/branches/lifetype-1.2/class/action/admin/admineditlinkact
> ion.class.php	2008-06-19 06:09:17 UTC (rev 6581)
> > +++ 
> plog/branches/lifetype-1.2/class/action/admin/admineditlinkact
> ion.class.php	2008-06-19 06:10:26 UTC (rev 6582)
> > @@ -27,12 +27,7 @@
> >
> > 			// data validation stuff
> > 			$this->registerFieldValidator( 
> "linkId", new IntegerValidator());
> > -			// we need to register the other fields 
> or else the form validation will complain
> > -            // TODO: validate or don't use
> > -			$this->_form->registerField( 
> "linkDescription" );
> > -			$this->_form->registerField( "linkName" );
> > -			$this->_form->registerField( "linkRssFeed" );
> > -			$this->_form->registerField( "linkUrl" );
> > +
> > 			$view = new AdminLinksListView( 
> $this->_blogInfo );
> > 			$view->setErrorMessage( 
> $this->_locale->tr("error_fetching_link" ));
> > 			$this->setValidationErrorView( $view );
> >
> > _______________________________________________
> > pLog-svn mailing list
> > pLog-svn at devel.lifetype.net
> > http://limedaley.com/mailman/listinfo/plog-svn
> >
> 
> --
> Jon Daley
> http://jon.limedaley.com
> ~~
> I was unhappy...but that's over, done, water under the dam.
> -- Cal Ripkin Sr.
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn