[pLog-svn] r6528 - in plog/branches/lifetype-1.2/class: dao/userdata view/admin

[Mark Wu]

Yes, but it should be okay validate in $view.

You can see we vlidate the value and if the value is not valid, we juts
assign a defualt  value to it.

 Mark

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Monday, June 09, 2008 7:35 PM
> To: LifeType Developer List
> Subject: Re: [pLog-svn] r6528 - in 
> plog/branches/lifetype-1.2/class: dao/userdata view/admin
> 
>  	Should the variable be validated in the action?  Oh, 
> right, now I remember.  The view has the validation code 
> right below it already, that's why I didn't change it before.
> 
> On Mon, 9 Jun 2008, mark at devel.lifetype.net wrote:
> > 1. We should not use HttpVars::getRequestValue() in any 
> situation, unless we need the raw request.
> >
> > 2. We can use $this->_request->getValue() or 
> $this->_request->getFilteredValue() in $view. It better to 
> use getFilteredValue(), since there is no 
> registerFiledValidator in $view. So, we can get a cleaned 
> input data from getFilteredValue() function.
> 
> > Modified: 
> > 
> plog/branches/lifetype-1.2/class/view/admin/adminsiteuserslistview.cla
> > ss.php 
> > ===================================================================
> > --- 
> plog/branches/lifetype-1.2/class/view/admin/adminsiteuserslist
> view.class.php	2008-06-09 08:08:04 UTC (rev 6527)
> > +++ 
> plog/branches/lifetype-1.2/class/view/admin/adminsiteuserslist
> view.class.php	2008-06-09 10:21:48 UTC (rev 6528)
> > @@ -41,7 +41,7 @@
> > 		 */
> > 		function getStatusFromRequest()
> > 		{
> > -			$status = HttpVars::getRequestValue( "status" );
> > +			$status = 
> $this->_request->getFilteredValue( "status", new 
> > +HtmlFilter() );
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn