[pLog-svn] r6503 -plugins/branches/lifetype-1.2/editcomments/class/action

[fabian büttner]

What, Oscar left?!
I thought he's about to come back?

What's wrong about the architecture?
Maybe we should change it?
But I am not that experienced with the code, that's why you'd have to
tell me/us what parts have to be rewritten etc.

I always wondered how long you'd stay...
Anyway, let's get it on, IIRC 2.0 should already have been released ;)

On Thu, 2008-06-05 at 22:32 -0400, Jon Daley wrote:
> 	The project hasn't been as fun as it was since Oscar left.  I 
> don't really feel like I am working on a team, just me doing everything. 
> I have thought about leaving a number of times, and more about it today. 
> It wouldn't really change anything for me, ie. I would fork the project, 
> and continue developing as I am, but I wouldn't answer stuff on the 
> forums, so I would have more time to code, and less time discussing why 
> someone else thinks their way is better, on something that hardly matters, 
> and their method isn't any better than the current version.
>  	I would have a whole lot less administrative work, and more fun 
> coding.
>  	I am disappointed in the architecture, and how hard it is to 
> validate the inputs.  It is very likely that whenever a new input is 
> added, it won't be validated appropriately.  A number of our current 
> validators aren't very good, there are security holes all over the place. 
> I guess it is because lifetype is small enough so the spammers haven't 
> taken that much notice of it.
>  	Questioning commits is fine, and that is a good thing.  Lots of 
> bugs have been fixed by others watching the commits.  In this case, your 
> solution at best isn't any better than mine, and as I have argued, is less 
> clear about what values are accepted than a simple regular expression that 
> any php developer can understand exactly how it works.  Casting in most 
> programming languages is the wrong solution to almost every problem, and 
> while php does a better job than some languages, I wouldn't want to work 
> on any code that uses casts to do validation, that isn't what they are 
> made for.
>  	Probably more frustration than anger, I think.