[pLog-svn] r6318 - plog/branches/lifetype-1.2

[Jon Daley]

 	Be careful on this one.  I believe I added this code - we didn't 
used to ever drop the table at all, and just it in the database 
permanently.  So, as long as you make sure it is getting dropped at the 
end (on either a failure or success), it should be okay.

On Thu, 24 Apr 2008, mark at devel.lifetype.net wrote:

> Author: mark
> Date: 2008-04-24 14:11:23 -0400 (Thu, 24 Apr 2008)
> New Revision: 6318
>
> Modified:
>   plog/branches/lifetype-1.2/wizard
> Log:
> Another serious bug in wizard when we perform upgrade. We just drop the tmp_users_permission table in the first while loop.
>
> The users_permissions table never convert "complete" when user upgrade from 1.1 :(
>
> The same question, why there are no user complain about this.
>
> Modified: plog/branches/lifetype-1.2/wizard
> ===================================================================
> --- plog/branches/lifetype-1.2/wizard	2008-04-24 16:11:05 UTC (rev 6317)
> +++ plog/branches/lifetype-1.2/wizard	2008-04-24 18:11:23 UTC (rev 6318)
> @@ -1537,6 +1537,7 @@
>             $res3 = $this->Execute( $query3, $this->page, $this->itemsPerPage );
>             if( $res3->RecordCount() == 0 ) {
> 				$this->message .= "No more records to process";
> +				$this->Execute("DROP TABLE ".Db::getPrefix()."tmp_users_permissions");
> 				return( true );
> 			}
>
> @@ -1563,12 +1564,12 @@
> 						}
> 					}
> 				}
> +
> +				$this->updatedRecords++;
>             }
>
>             $this->message .= "{$this->updatedRecords} users updated (".$this->getPercentProcessed()."%%)<br/>";
>
> -            $this->Execute("DROP TABLE ".Db::getPrefix()."tmp_users_permissions");
> -
>             return true;
>         }
>     }
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

You can tell a lot about a fellow's character by his way of eating jellybeans.
-- Ronald Reagan