[pLog-svn] r6088 - plog/branches/lifetype-1.2/class/security

[Mark Wu]

Hi Jon:

I really need you to look the code carefully again.

What you do is make the bayesian filter  work worse not better.

There are several plugins use pipeline filter, we take authimage,
host-block, anti-dns-spam, content-filter as exmple:

If one of them failed, you ask baysianFilter to training the comment as a
spam, It is not a good idea.

1. Authimage failed: it is due to user input wrong code, but he is not spam.

2. host-block: some one keep post something from some IP, but the content is
not spam, and the "IP" yes .... and our bayesian does not training IP

3. anti-dns: the same as host block

4. content filter: We just don't want some "word" to post into our comment,
but it is not spam.

So, in this case, you input noise into bayesianFilter and make the result
worse. 

And, If you DO reallty won't to solve the order problem, we should add a
priority to register filter , like

$registerFilter( $filter, $priority )

And, before we run the process(), we need to sort the global filter array()
by priority. That's the right method.

Becasue we can always put the baysianFilter in the last order everytime.

Nit just run them twice, and add a "hacky" secondRun flag there to avoid
filter to something.

Mark

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Friday, November 30, 2007 1:13 AM
> To: LifeType Developer List
> Subject: Re: [pLog-svn] r6088 - 
> plog/branches/lifetype-1.2/class/security
> 
> On Thu, 29 Nov 2007, Jon Daley wrote:
> > 	Actually, now that I look at it again, why does the 
> bayesian filter 
> > add the comment to the comments database at all?  The 
> addcommentaction 
> > already takes care of that, doesn't it?
>  	Ah, because if it is spam, the addcommentaction won't 
> be called, right.
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn