[pLog-svn] r6088 - plog/branches/lifetype-1.2/class/security

[Mark Wu]

Hi Jon:

Actaully 6088 and 6089 is the same. 

in 6088.

array(
"NullFilter" = > false,
"CommentFilter" = > false,
"BaysianFilter" = > false, 
"AuthImage" =>false
)

foreach( $filters as $filter)
{
if( $filters == fail)
stop
}

We suppose is fails in BayesianFilter , so, after 1st run the array() will
become

array(
"NullFilter" = > true,
"CommentFilter" = > true,
"BaysianFilter" = > true, <== break after this in 1st tun
"AuthImage" =>false <== start run this in 2nd run
)

foreach( $filters as $filter => $executed )
{
if(!$executed)
   if( $filters == fail)
   stop
}
}

Becasue we stop (break) afetr BaysianFilter, so the AuthImage did not
executed in 1st run.

Then, we go to 2nd, we did not run those executed one, and just run
authimage

=====

in 6089.

I run all filters and "without" stop or say "break"....

foreach( $filters as $filter)
{
if( $filters == fail)
    $this->_result = $filters->gerResult();
}

So, I say I can sure it run "ALL"  filters once.

Mark

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Thursday, November 29, 2007 10:46 PM
> To: LifeType Developer List
> Subject: Re: [pLog-svn] r6088 - 
> plog/branches/lifetype-1.2/class/security
> 
> On Thu, 29 Nov 2007, Mark Wu wrote:
> > As I said in previous mail, it is not a problemjust becasue 
> we "hide" it ...
>  	Yes, I agree with this part.  But, if there was a flag 
> that said "already executed" then auth image would say, I 
> don't need to run twice, and exit out quickly.  And other 
> plugins can run twice if they want to.
>  	I think you added the execute flag, so that was good, 
> but running the pipeline twice is also good, so that part 
> needs to be changed back.
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn