[pLog-svn] r6088 - plog/branches/lifetype-1.2/class/security

[Oscar Renalias]

Two things:

- If you only run the filters once, how do you ensure that all those
filters that want to do some cleanup work, actually get to do that
cleanup work?

- The pipeline has been working like this for a while now. When you
fixed the issue related to XSS when the bayesian filter runs (as this
is from where this conversation started), did the fact that the
pipeline runs twice break something else? Because if it didn't break
anything else, perhaps we shouldn't fix what ain't broken? :)

Oscar

On Nov 29, 2007 4:09 PM, Mark Wu <markplace at gmail.com> wrote:
> >       Well, hopefully Paul will chime in here.  I am pretty
> > sure I understand what you did.  Did you read Paul's (I
> > assume it was Paul) comment about why he added the second
> > loop?  I think we need to run the entire pipeline twice,
> > particularly those filters that ran the first time.
>
> Yep, I read his comments about add second run , that why I think the change
> is okay for us. Becasue I can make sure all pipeline filters run once. No
> more no less :D
>
> Hope he can give me some advice, but seems he did not show up in this
> mailling for a long time.
>
> >       The thing that we need to have is the "executed" flag
> > passed into each filter, and then each filter can decide
> > whether it wants to run twice or not.
>
> Yes, this is what I did in rev. 6088.
>
> After review the whole pipeline class, I decide to combine these two
> for-loop together in rev. 6089, It makes the code easier to understand and
> "less" code.
>
> BTW, did you test it yet? Does it work for you?
>
> Mark
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>