[pLog-svn] r5183 - plog/branches/lifetype-1.2/class/action/admin

[Jon Daley]

 	That makes sense. I think I was just playing in that code, or 
maybe it was code that just looks really similar, so I am sort of 
surprised that I didn't notice it when I was working on it.  Thanks for 
fixing it.

  On Mon, 26 Mar 2007, Mark Wu wrote:

> Nope, it won't.
>
> In our previous imlementation 1.1, we use two forms to represent postText
> and postExtentedTxt ...
>
> So, we need to combine them together use [@more@] string before add or
> update it in articles_text table.
>
> But, in our new implemenation 1.2 or later,  we only have one form
> "postText", and the "postExtendedText" does not exist anymore...
>
> So, we should remove it. Kindly check the code in
> /class/action/adminpostmanagementcommonaction.class.php
>
> If other plugins still use postExtendedText field when update or add
> articles, I think we should remove them, too.
>
> Mark
>
>> -----Original Message-----
>> From: plog-svn-bounces at devel.lifetype.net
>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
>> Paul Westbrook
>> Sent: Monday, March 26, 2007 11:15 AM
>> To: plog-svn at devel.lifetype.net
>> Subject: Re: [pLog-svn] r5183 -
>> plog/branches/lifetype-1.2/class/action/admin
>>
>> Hello,
>>     I agree.  If you update a post that has extended text,
>> this change appears to lose the extended text.
>>
>> --Paul
>>
>>
>> On Mar 25, 2007, at 8:06 PM, Jon Daley wrote:
>>
>>>  	I don't understand this fix.  You no longer append the extended
>>> text?  Is this the code I just added a little bit ago, from our
>>> discussion about automatically added the <more> tag to
>> every post?  I
>>> haven't tried it, so maybe it works, it just seems odd that
>> you could
>>> remove this add not have side-effects somewhere else.
>>>
>>> On Sun, 25 Mar 2007, mark at devel.lifetype.net wrote:
>>>
>>>> Author: mark
>>>> Date: 2007-03-25 12:31:45 -0400 (Sun, 25 Mar 2007) New
>> Revision: 5183
>>>>
>>>> Modified:
>>>>   plog/branches/lifetype-1.2/class/action/admin/
>>>> adminupdatepostaction.class.php
>>>> Log:
>>>> Fixed a PHP5 notice.
>>>>
>>>> Modified: plog/branches/lifetype-1.2/class/action/admin/
>>>> adminupdatepostaction.class.php
>>>> ===================================================================
>>>> --- plog/branches/lifetype-1.2/class/action/admin/
>>>> adminupdatepostaction.class.php	2007-03-25 15:29:37 UTC
>> (rev 5182)
>>>> +++ plog/branches/lifetype-1.2/class/action/admin/
>>>> adminupdatepostaction.class.php	2007-03-25 16:31:45 UTC
>> (rev 5183)
>>>> @@ -107,8 +107,6 @@
>>>>              // if we got it, update some fields
>>>>             $post->setTopic( stripslashes($this->_postTopic));
>>>>             $postText = $this->_postText;
>>>> -            if($this->_postExtendedText)
>>>> -                $postText .= POST_EXTENDED_TEXT_MODIFIER.$this-
>>>>> _postExtendedText;
>>>>             $post->setText( stripslashes($postText));
>>>>             $post->setTopic( $this->_postTopic );
>>>>             $post->setText( $postText );
>>>>
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>>
>>>
>>> --
>>> Jon Daley
>>> http://jon.limedaley.com/
>>>
>>> There is no "I" in Team, but it does contain a silent "scapegoat"
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://limedaley.com/mailman/listinfo/plog-svn
>>
>> --
>> Paul Westbrook
>> paul at westbrooks.org
>> <http://www.westbrooks.org>
>>
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://limedaley.com/mailman/listinfo/plog-svn
>>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

If you obey all the rules, you miss all the fun.
-- Katharine Hepburn