[pLog-svn] r5062 - plog/branches/lifetype-1.2/class/data

Wed Mar 14 10:49:47 EDT 2007

This last version will break searches for users of non-utf-8  
character sets, as it saves utf-8 characters into a latin-1 database.  
The side effect is that searches won't work, because words with  
accented characters are represented with different bytes in utf-8 and  
latin-1.

Mark and I seem to have found a solution, he'll be checking in the  
changes shortly.

On 14 Mar 2007, at 16:43, Jon Daley wrote:

> I just got the latest and the slug and the title look to be okay to  
> me.
> Since I explicitly mentioned &nbsp; in my commit message, I am  
> confused as
> to why I would have cared given that slugs don't have spaces in them
> anyway - unless the slug code was fixed later - I did work on it to  
> make
> it better at some point.
>
> On Wed, 14 Mar 2007, Oscar Renalias wrote:
>
>> htmlDecode is apparently only called from Texfilter::normalizeText()
>> and Textfilter::slugify(), nothing else.
>>
>> But now that I look at this, how can this be the cause for the issues
>> you Mark were mentioning? Where exactly was htmlDecode() causing  
>> issues?
>>
>> On 14 Mar 2007, at 05:22, Mark Wu wrote:
>>
>>> I think I found a way to fixied it. But still under test!!
>>>
>>> We encode our key to UTF-8 before we use it.
>>> 	function htmlDecode( $htmlString, $quote_style = ENT_QUOTES )
>>> 	{
>>>             // replace numeric entities
>>>             $htmlString = preg_replace('~&#x([0-9a-f]+);~ei',
>>> 'chr(hexdec("\\1"))', $htmlString);
>>>             $htmlString = preg_replace('~&#([0-9]+);~e', 'chr(\\1)',
>>> $htmlString);
>>>             // replace literal entities
>>>             $trans_table = get_html_translation_table 
>>> ( HTML_ENTITIES,
>>> $quote_style );
>>> 	foreach ( $trans_table as $key => $value ){
>>> 		$utf8_trans_table[$value] = utf8_encode( $key );
>>> 	}
>>>             return strtr( $htmlString, $utf8_trans_table );
>>> 	}
>>>
>>>
>>> Another problem is, this only works under utf-8, about other
>>> characters, I
>>> have no idea...
>>>
>>> So, we need to get the character set from current locale and pass
>>> it into
>>> textfilter, I afirad it will change a lot.
>>>
>>> Any good way to pass to encoding/character set information to
>>> textfilter?
>>>
>>> Mark
>>>> -----Original Message-----
>>>> From: plog-svn-bounces at devel.lifetype.net
>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
>>>> Oscar Renalias
>>>> Sent: Tuesday, March 13, 2007 11:40 PM
>>>> To: plog-svn at devel.lifetype.net
>>>> Subject: Re: [pLog-svn] r5062 - plog/branches/lifetype-1.2/class/ 
>>>> data
>>>>
>>>> Or how about using mb_eregi_replace() for the regular
>>>> expression, if available?
>>>>
>>>> On 3/13/07, Oscar Renalias <oscar at renalias.net> wrote:
>>>>> As Jon said, htmlDecode should be the opposite of
>>>> filterHtmlEntities:
>>>>>
>>>>> $x = filterHtmlEntities(htmlDecode($x))
>>>>>
>>>>> So you can basically get the output of several strings
>>>> passed through
>>>>> filterHtmlEntities and then make sure that htmlDecode can
>>>> revert them
>>>>> back to what they were in the beginning. Jon may be able to
>>>> give you
>>>>> more precise examples.
>>>>>
>>>>> Oh and a test case would be good too, just to make sure :)
>>>>>
>>>>> On 3/13/07, Mark Wu <markplace at gmail.com> wrote:
>>>>>> Hi Jon:
>>>>>>
>>>>>> I am looking this problem now, do you have any real
>>>> example for me to test?
>>>>>>
>>>>>> Mark
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: plog-svn-bounces at devel.lifetype.net
>>>>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Reto
>>>>>>> Hugi
>>>>>>> Sent: Tuesday, March 13, 2007 10:32 PM
>>>>>>> To: plog-svn at devel.lifetype.net
>>>>>>> Subject: Re: [pLog-svn] r5062 -
>>>>>>> plog/branches/lifetype-1.2/class/data
>>>>>>>
>>>>>>> Jon Daley wrote:
>>>>>>>>     We can go ahead with it as it is, we probably
>>>> should put a
>>>>>>>> note somewhere that tells people how to fix it if
>>>> they care about this.
>>>>>>>> And then, hopefully, Mark can see if there is a way to fix it
>>>>>>>> correctly for everyone.
>>>>>>>>
>>>>>>>
>>>>>>> if this would include something like "sorry if we broke it.
>>>>>>> if you want to fix it, take file xxx.php and replace it
>>>> with the
>>>>>>> currently distributed one" I would say we hold the
>>>> release back a
>>>>>>> couple of days to fix this issue once and for all. Isn't typing
>>>>>>> stuff in a textarea (maybe on top of a wysiwyg editor) what any
>>>>>>> basic blogging tool should actually do best?
>>>>>>>
>>>>>>> reto
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> pLog-svn mailing list
>>>>>>> pLog-svn at devel.lifetype.net
>>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>>>>
>>>>>> _______________________________________________
>>>>>> pLog-svn mailing list
>>>>>> pLog-svn at devel.lifetype.net
>>>>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>>>>
>>>>>
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>>
>>>
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://limedaley.com/mailman/listinfo/plog-svn
>>
>
> -- 
> Jon Daley
> http://jon.limedaley.com/
>
> The ultimate measure of a man is not where he stands in
> moments of comfort, but where he stands at times of challenge.
> -- Martin Luther King, Jr.
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>