[pLog-svn] r5080 - plugins/branches/lifetype-1.2/authimage/templates

[Jon Daley]

On Tue, 13 Mar 2007, Reto Hugi wrote:
> Oscar Renalias wrote:
>> On 3/13/07, Reto Hugi <plog at hugi.to> wrote:
>>> Oscar Renalias wrote:
>>>> Otherwise plugin code gets too messy, as for each one of the settings
>>>> we'd need to check if overrideable and if so save it, or discard the
>>>> value otherwise. The whole point of the global settings framework was
>>>> that it could be implemented with little or no effort (although it
>>>> turned out to be "little effort" rather than "no effort" :))
>>>
>>> ok, but jon and I struggled over the validation error messages in "mixed
>>> scenarios", where parts of the plugin configuration is overrideable and
>>> parts are not (firefox will not send values for form values that are
>>
>> I just tested this and firefox is sending form values for readonly
>> values. I thought the point of the change was to replace "disabled"
>> with "readonly", right? The current version of the authimage plugin
>> works fine, all values from the form are sent and saved successfully.
>
> ok, I can't remember what the problem was. if replacing "disabled" with
> "readonly" already fixes it, it's fine.


 	Yes, readonly does the right thing and sends the value.  It is 
then saved in the blogsettings, but Oscar says that getValue will always 
grab the global value as appropriate.  I didn't check the source, but that 
is how it appeared to behave from the GUI side.  So, yes, I think it is 
fine.  We probably just need to change the existing plugin templates to 
use readonly instead of disabled for the text boxes.  Checkboxes need to 
be disabled.  Radio buttons don't work yet.