[pLog-svn] r5015 - plog/branches/lifetype-1.2/class/action

[Jon Daley]

 	Right - I meant always wrong for me.  I thought I sometimes was 
getting oldest first sorting.

On Wed, 7 Mar 2007, Oscar Renalias wrote:

> It was using '1' as the sorting mode, which equals to newest first I
> think... That means that it wasn't always the wrong order, it all
> depended on your settings :)
>
> On 3/7/07, Jon Daley <plogworld at jon.limedaley.com> wrote:
>>         This fix seems like it would always have the wrong order?  I don't
>> think that was the behavior I saw, but maybe I didn't look carefully
>> enough.
>>         I updated the code, and I am currently seeing them in the right
>> order.  I'll be more convinced after some time goes by.
>>
>> On Wed, 7 Mar 2007, oscar at devel.lifetype.net wrote:
>>
>>> Author: oscar
>>> Date: 2007-03-07 07:10:10 -0500 (Wed, 07 Mar 2007)
>>> New Revision: 5015
>>>
>>> Modified:
>>>   plog/branches/lifetype-1.2/class/action/viewarticleaction.class.php
>>> Log:
>>> fixed issue with the comment sorting... a very silly one, btw :)
>>>
>>>
>>> Modified: plog/branches/lifetype-1.2/class/action/viewarticleaction.class.php
>>> ===================================================================
>>> --- plog/branches/lifetype-1.2/class/action/viewarticleaction.class.php       2007-03-06 21:56:29 UTC (rev 5014)
>>> +++ plog/branches/lifetype-1.2/class/action/viewarticleaction.class.php       2007-03-07 12:10:10 UTC (rev 5015)
>>> @@ -248,8 +248,9 @@
>>>                       if( $commentsPerPage > $hardLimit ) $commentsPerPage = $hardLimit;
>>>
>>>                       $comments = new ArticleComments();
>>> +            $order = $blogSettings->getValue( "comments_order", COMMENT_ORDER_NEWEST_FIRST );
>>>                       $postComments = $comments->getPostComments( $article->getId(),
>>> -                                                                 $order = COMMENT_ORDER_NEWEST_FIRST,
>>> +                                                                 $order,
>>>                                                                   COMMENT_STATUS_NONSPAM,
>>>                                                                   $this->_page,
>>>                                                                   $commentsPerPage );
>>>
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://limedaley.com/mailman/listinfo/plog-svn
>>>
>>
>> --
>> Jon Daley
>> http://jon.limedaley.com/
>>
>> For many people, one of the most frustrating aspects of life is not
>> being to understand other people's behavior.  We see them as "guilty"
>> instead of "innocent."
>> -- Unknown
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://limedaley.com/mailman/listinfo/plog-svn
>>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

The sooner you fall behind, the more time you'll have to catch up.