[pLog-svn] r4934 - plog/branches/lifetype-1.2/templates/admin

Jon Daley plogworld at jon.limedaley.com
Fri Mar 2 14:08:37 EST 2007


 	I am not sure what this is supposed to do.  Right now, the 
blog_setting value is directly used as the parameter name, untranslated.
 	Now that I removed the smarty typo, the configuration values are 
actually getting set to something, and that value is incorrect.
 	It seems like we need a table to store the global values, and then 
grab the value from there, rather than from the plugin, since the plugin 
might have a useful default value, but doesn't know what the current 
globally set value is.
 	As far as translating goes, it seems that we either have to 
enforce that plugins have a translation for their configuration settings, 
named exactly the same thing, which probably isn't a bad idea, otherwise, 
they would have to provide the translation key in the 
getPluginConfigurationKeys array.

On Fri, 2 Mar 2007, jondaley at devel.lifetype.net wrote:

> Author: jondaley
> Date: 2007-03-02 14:05:20 -0500 (Fri, 02 Mar 2007)
> New Revision: 4934
>
> Modified:
>   plog/branches/lifetype-1.2/templates/admin/pluginsettings.template
> Log:
> typo
>
> Modified: plog/branches/lifetype-1.2/templates/admin/pluginsettings.template
> ===================================================================
> --- plog/branches/lifetype-1.2/templates/admin/pluginsettings.template	2007-03-02 19:02:21 UTC (rev 4933)
> +++ plog/branches/lifetype-1.2/templates/admin/pluginsettings.template	2007-03-02 19:05:20 UTC (rev 4934)
> @@ -21,7 +21,7 @@
> 		{assign var=pluginsettings value=$plugin->getPluginConfigurationKeys()}
> 		{foreach from=$pluginsettings item=setting}
> 		 <tr>
> -			{assignvar var=key value=$setting.name}
> +			{assign var=key value=$setting.name}
> 			{assign var=name value=$setting.name}
> 			{assign var=overrideValue value=$canOverride[$setting.name]}
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

I haven't lost my mind; I have a tape backup somewhere.


More information about the pLog-svn mailing list