[pLog-svn] recent comments plugin change: rev 5277
Jon Daley
plogworld at jon.limedaley.com
Sun Jul 8 20:26:22 EDT 2007
That is fine, although I have two comments, one, I'd rather change
getRecentComments() to have a parameter which defaults to comments only.
The other thing is that "backwards compatibilty" only means since 1.2,
since in 1.1, it returned both comments and trackbacks, though I suppose
maybe in 0.3.2 (and 1.0) it only returned comments, since that was before
the commentsCommon class existed, I think.
But, anyway, keeping the default the way it is in 1.2 is fine with
me, I just don't want to have duplicate code that then needs to get
updated twice.
On Mon, 9 Jul 2007, Mark Wu wrote:
> Hi Jon:
>
> The problem is some users complain to me about the recentcomments show the
> trackbacks information, they hope the recentcomments works as the way
> before.
>
> I will suggest we create a new method in $recentcomment, like
> getComments&Trackbacks() get show all comments & trackbacks, instead of use
> the original method.
>
> It can maintain the backward compatibility.
>
> Regards, Mark
>
> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Saturday, July 07, 2007 3:21 AM
> To: LifeType SVN
> Subject: [pLog-svn] recent comments plugin change: rev 5277
>
> I hadn't noticed that the recentcomments plugin no longer displays
> trackbacks. Can I put that back in? I am not sure if it was intentionally
> removed when Mark (correctly) removed the hard-coded SQL in rev 5277 to
> instead use the dao layer.
> I know there is the recenttrackbacks plugin, but is nice having them
> altogether. I could add a parameter to getRecentComments() and default it
> to comments only, if you would like.
>
> ---------- Forwarded message ----------
> Date: Fri, 06 Jul 2007 14:58:20 -0400
> From: Linda Wightman <LPHJ at SalemsAttic.com>
> To: Jon Daley <jon at limedaley.com>
> Subject: Re: upgrade
>
> Logging off and back in again did not change anything, but when I closed
> Firefox and reopened it, the problem went away.
>
> I did have a trackback that went away, though. I forgot to tell you that
> the first time. Actually, It still exists
> (http://sca.salemsattic.com/lwblog/post/1/808), but no longer shows up in my
> Recent Comments section. Probably something I need to change in my sidebar
> code?
>
> Linda Wightman
> http://sursumcorda.salemsattic.com
>
>
> Jon Daley wrote:
>> That is strange. I get the message (on my blog and yours) with
>> the correct graphic and text.
>>
>> On Fri, 6 Jul 2007, Linda Wightman wrote:
>>
>>> Thanks! I'm looking forward to seeing what's new.
>>>
>>> One thing that I see right away that may not be intentional. In the
>>> screenshot below you can see that under the newPost heading it says
>>> "warning_autosave_message." I suspect that's supposed to be telling
>>> me that I left this screen without saving my post, but it could be a
>>> little clearer.... ;)
>>>
>>> Linda
>>>
>>>
>>> --
>>> Linda Wightman
>>> http://sursumcorda.salemsattic.com
>>>
>>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>
--
Jon Daley
http://jon.limedaley.com/
I never think of the future. It comes soon enough.
-- Albert Einstein
More information about the pLog-svn
mailing list