[pLog-svn] r5602-plog/branches/lifetype-1.2/class/xml/rssparser/magpierss

[Mark Wu]

I have the same thought in the beginning ...

But the problem is if we do that, then we just add the burden back to
lt_include() ...

Maybe sveral "ms" per include ...

So, I decide to change the path definition instead of add the burden back to
it_include()

Mark 

-----Original Message-----
From: plog-svn-bounces at devel.lifetype.net
[mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
Sent: Monday, July 02, 2007 7:26 PM
To: LifeType Developer List
Subject: Re: [pLog-svn]
r5602-plog/branches/lifetype-1.2/class/xml/rssparser/magpierss

 	Or probably lt_include should strip out \ and / before checking the
string?

On Mon, 2 Jul 2007, Mark Wu wrote:

> Hi all:
>
> It is really a weird bug. Only happened under windows, because the 
> path is different from we get in linux.
>
> So, I have to change the magpie_dir definition and make it works under 
> both linux and windows.
>
> Mark
>
> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of 
> mark at devel.lifetype.net
> Sent: Monday, July 02, 2007 4:46 PM
> To: plog-svn at devel.lifetype.net
> Subject: [pLog-svn] r5602
> -plog/branches/lifetype-1.2/class/xml/rssparser/magpierss
>
> Author: mark
> Date: 2007-07-02 04:45:51 -0400 (Mon, 02 Jul 2007) New Revision: 5602
>
> Modified:
>   
> plog/branches/lifetype-1.2/class/xml/rssparser/magpierss/rss_fetch.inc
> Log:
> It is a weird bug.
>
> The magpie_dir get from windows is 
> "C:\PHP5\lifetype\class\xml\magpie", but we defined in rssparser.php is
"C:\PHP5\lifetype\class/xml/magpie".
>
> The lt_include will treat it as two different path, so the file will 
> include again ....
>
> The patch I commited fixed this bug under windows.
>
> Modified:
> plog/branches/lifetype-1.2/class/xml/rssparser/magpierss/rss_fetch.inc
> ===================================================================
> --- 
> plog/branches/lifetype-1.2/class/xml/rssparser/magpierss/rss_fetch.inc
> 2007-07-02 07:29:02 UTC (rev 5601)
> +++ plog/branches/lifetype-1.2/class/xml/rssparser/magpierss/rss_fetch
> +++ .inc
> 2007-07-02 08:45:51 UTC (rev 5602)
> @@ -24,14 +24,14 @@
> }
>
> if (!defined('MAGPIE_DIR')) {
> -    define('MAGPIE_DIR', dirname(__FILE__) . DIR_SEP);
> +    define('MAGPIE_DIR',
> + PLOG_CLASS_PATH.'class/xml/rssparser/magpierss/');
> }
>
> lt_include( MAGPIE_DIR . 'rss_parse.inc' );  lt_include( MAGPIE_DIR .
> 'rss_cache.inc' );
>
> // for including 3rd party libraries
> -define('MAGPIE_EXTLIB', MAGPIE_DIR . 'extlib' . DIR_SEP);
> +define('MAGPIE_EXTLIB', MAGPIE_DIR . 'extlib/' );
> lt_include( MAGPIE_EXTLIB . 'Snoopy.class.inc');
>
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://limedaley.com/mailman/listinfo/plog-svn
>

--
Jon Daley
http://jon.limedaley.com/

It is easier to get forgiveness than permission.
-- Stewart's Law of Retroaction
_______________________________________________
pLog-svn mailing list
pLog-svn at devel.lifetype.net
http://limedaley.com/mailman/listinfo/plog-svn