[pLog-svn] r4569 - plog/branches/lifetype-1.1.5/js/ui

Oscar Renalias oscar at renalias.net
Wed Jan 24 18:41:28 GMT 2007


The problem is that the UsernameValidator class that is used to  
validate a username will reject it if it's got upper case letters in  
it, so the problem was that while the Ajax validation of uppercase  
usernames worked (because it was lowercasing everything before  
checking), you'd get an error upon clicking the "Next" button to move  
onto the next step.

Of course there was an alternative fix for this case: instead of  
removing the lowercasing of the ajax check, add extra code to the PHP  
validation to lowercase before validating. I guess they're both valid...

On 24 Jan 2007, at 20:19, Jon Daley wrote:

> 	Okay.  But the answer to the mysql problem is to lowercase  
> everything?  Maybe we should just do it at the ajax step too?
>
> On Wed, 24 Jan 2007, Oscar Renalias wrote:
>
>> No, this isn't solving the issue with MySQL, it's just about a  
>> minor UI issue (the ajax based "check username" button in  
>> register.php returning valid and the validation in the next step  
>> marking the username as invalid at the same time)
>>
>> On 24 Jan 2007, at 20:07, Jon Daley wrote:
>>
>>> 	I thought you did know about this - something about mysql not  
>>> being case-sensitive or something, at least on some platforms.  I  
>>> expected the fix to be to convert all usernames to lower case,  
>>> everywhere, and in the wizard during an upgrade.
>>> 	Surely the summary.js check is not causing the errors people are  
>>> having after upgrading.
>>> On Wed, 24 Jan 2007, oscar at devel.lifetype.net wrote:
>>>> Author: oscar
>>>> Date: 2007-01-24 17:25:17 +0000 (Wed, 24 Jan 2007)
>>>> New Revision: 4569
>>>> Modified:
>>>>  plog/branches/lifetype-1.1.5/js/ui/summary.js
>>>> Log:
>>>> I can't possible understand the reasons why the username should  
>>>> be converted to lower case but this is now causing an issue.  
>>>> I've removed it unless somebody can see a reason for this...  
>>>> This also fixes Mantis issue 1156 (http://bugs.lifetype.net/ 
>>>> view.php?id=1156)
>>>> Modified: plog/branches/lifetype-1.1.5/js/ui/summary.js
>>>> ===================================================================
>>>> --- plog/branches/lifetype-1.1.5/js/ui/summary.js	2007-01-24  
>>>> 14:54:52 UTC (rev 4568)
>>>> +++ plog/branches/lifetype-1.1.5/js/ui/summary.js	2007-01-24  
>>>> 17:25:17 UTC (rev 4569)
>>>> @@ -1,7 +1,7 @@
>>>> function checkUserNameAjax()
>>>> {
>>>> 	var userName = $F('userName');
>>>> -	userName = userName.toLowerCase();
>>>> +	//userName = userName.toLowerCase();
>>>> 	if (userName != '')
>>>> 	{
>>>> 		var url = plogSummaryBaseUrl;
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>> -- 
>>> Jon Daley
>>> http://jon.limedaley.com/
>>> I give money for church organs in the hope the organ music will
>>> distract the congregation's attention from the rest of the service.
>>> -- Andrew Carnegie
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>
> -- 
> Jon Daley
> http://jon.limedaley.com/
>
> Hat: A creation that will never go out of style;
> it will just look ridiculous year after year.
> -- Fred Allen
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>



More information about the pLog-svn mailing list