[pLog-svn] r3999 - plog/branches/lifetype-1.1.1/class/net/xmlrpc

Oscar Renalias oscar at renalias.net
Fri Sep 22 17:15:01 GMT 2006


Mark,

since we're working on the xmlrpc APIs, it's a good time to fix this.  
Can you take care of it?

A test case would also be needed.

Thanks

On 22 Sep 2006, at 20:06, Mark Wu wrote:

> Another bug is in metaWeblogGetCategories, but it is not really our  
> bug.
>
> Because wordpress and movable type implement some their own  
> parameters, and
> it makes the remote blogging tool have to support(or just only  
> support)
> those unofficial parameters...
>
> For example, We have to add the following parameters, to make  
> lifetype can
> work with windows live writer.
>
> Change
>
> 	            foreach($cats as $cat)
> 	            {
> 	                $dummy                   = array();
> 	                $dummy["description"]    = $cat->getDescription();
>
> 	                // disable the generation of xhtml content or else
> the IXR_XMLRPC library will
> 	                // escape things twice!
> 	                $url->setXHTML( false );
>
> 	                $dummy["htmlUrl"]        = $url->categoryLink( $cat
> );
> 	                $dummy["rssUrl"]         = "http://";
> 	                $ret[$cat->getName()]    = $dummy;
> 	            }
>
> To
>
> 	            foreach($cats as $cat)
> 	            {
> 	                $dummy                   = array();
> 	                $dummy['categoryId']     = $cat->getId();
> 	                $dummy['categoryid']     = $cat->getId();
> 	                $dummy['categoryName']   = $cat->_name;
> 	                $dummy["description"]    = $cat->_name;
> 	                $dummy["title"]          = $cat->_name;
>
> 	                // disable the generation of xhtml content or else
> the IXR_XMLRPC library will
> 	                // escape things twice!
> 	                $url->setXHTML( false );
>
> 	                $dummy["htmlUrl"]        = $url->categoryLink( $cat
> );
> 	                $dummy["rssUrl"]         = "http://";
> 	                $ret[$cat->getName()]    = $dummy;
> 	            }
>
> Mark
>
>
>> -----Original Message-----
>> From: plog-svn-bounces at devel.lifetype.net
>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
>> Paul Westbrook
>> Sent: Saturday, September 23, 2006 12:05 AM
>> To: plog-svn at devel.lifetype.net
>> Subject: Re: [pLog-svn] r3999 -
>> plog/branches/lifetype-1.1.1/class/net/xmlrpc
>>
>> Hello,
>>     I don't see how the implementation of
>> metaWeblogNewMediaObject doesn't conform to the spec.
>>
>>
>> --Paul
>>
>>
>> On Sep 22, 2006, at 3:51 AM, Oscar Renalias wrote:
>>
>>> Paul, could I ask you to look into this?
>>>
>>> http://bugs.lifetype.net/view.php?id=1059
>>>
>>> It should be easy to fix but perhaps a bit tricky to create a test
>>> case... Can you at least provide a fix? We can look at the
>> test case
>>> later on.
>>>
>>> On 9/20/06, Paul Westbrook <paul at westbrooks.org> wrote:
>>>> Sure.  I'll do that tonight.
>>>>
>>>> --Paul
>>>>
>>>>
>>>> On Sep 20, 2006, at 3:25 AM, Oscar Renalias wrote:
>>>>
>>>>> Do you think you could update the test cases, or maybe
>> modify the
>>>>> current ones to test that this works as expected?
>>>>>
>>>>> On 9/20/06, pwestbro at devel.lifetype.net
>>>>> <pwestbro at devel.lifetype.net> wrote:
>>>>>> Author: pwestbro
>>>>>> Date: 2006-09-20 09:35:24 +0000 (Wed, 20 Sep 2006) New
>> Revision:
>>>>>> 3999
>>>>>>
>>>>>> Modified:
>>>>>>    plog/branches/lifetype-1.1.1/class/net/xmlrpc/
>>>>>> xmlrpcserver.class.php
>>>>>> Log:
>>>>>> The article text being returned by xmlrpc was having
>>>>>> POST_EXTENDED_TEXT_MODIFIER stripped out
>>>>>>
>>>>>>
>>>>>> Modified: plog/branches/lifetype-1.1.1/class/net/xmlrpc/
>>>>>> xmlrpcserver.class.php
>>>>>>
>>>> ===================================================================
>>>>>> --- plog/branches/lifetype-1.1.1/class/net/xmlrpc/
>>>>>> xmlrpcserver.class.php        2006-09-20 07:42:53 UTC (rev 3998)
>>>>>> +++ plog/branches/lifetype-1.1.1/class/net/xmlrpc/
>>>>>> xmlrpcserver.class.php        2006-09-20 09:35:24 UTC (rev 3999)
>>>>>> @@ -410,7 +410,7 @@
>>>>>>                                 $userInfo               = $item-
>>>>>>> getUserInfo();
>>>>>>                     $dummy["userid"]        =
>> $userInfo->getId();
>>>>>>                     $dummy["dateCreated"]   = new
>> IXR_Date($time);
>>>>>> -                   $dummy["content"]       =
>> $item->getTopic() .
>>>>>> "\r\n" . $item->getText() . " ";
>>>>>> +                   $dummy["content"]       =
>> $item->getTopic() .
>>>>>> "\r\n" . $item->getText(false) . " ";
>>>>>>                     $dummy["postid"]        = $item->getId();
>>>>>>
>>>>>>                                 $blogInfo =
>> $item->getBlogInfo();
>>>>>> @@ -464,7 +464,7 @@
>>>>>>                     $dummy["userid"]        =
>> $userInfo->getId();
>>>>>>                     $dummy["dateCreated"]   = new
>> IXR_Date($time);
>>>>>>                     $dummy["title"]         = $item->getTopic();
>>>>>> -                   $dummy["description"]   = $item->getText();
>>>>>> +                   $dummy["description"]   = $item->getText
>>>> (false);
>>>>>>                     $dummy["postid"]        = $item->getId();
>>>>>>
>>>>>>                     $dummy["link"]          = $url->postLink
>>>>>> ( $item );
>>>>>> @@ -758,7 +758,7 @@
>>>>>>                                         $userInfo
>>         =
>>>>>> $item->getUserInfo();
>>>>>>                         $dummy["userid"]        = $userInfo-
>>>>> getId();
>>>>>>                         $dummy["dateCreated"]   = new IXR_Date
>>>>>> ($time);
>>>>>> -                       $dummy["content"]       =
>> $item->getTopic
>>>>>> () . "\r\n" . $item->getText() . " ";
>>>>>> +                       $dummy["content"]       =
>> $item->getTopic
>>>>>> () . "\r\n" . $item->getText(false) . " ";
>>>>>>                         $dummy["postid"]        =
>> $item->getId();
>>>>>>
>>>>>>                         $ret[]                  = $dummy;
>>>>>> @@ -809,7 +809,7 @@
>>>>>>                         $dummy["userid"]        = $userInfo-
>>>>> getId();
>>>>>>                         $dummy["dateCreated"]   = new IXR_Date
>>>>>> ($time);
>>>>>>                         $dummy["title"]         = $item-
>>>>> getTopic();
>>>>>> -                       $dummy["description"]   =
>> $item->getText
>>>> ();
>>>>>> +                       $dummy["description"]   = $item->getText
>>>>>> (false);
>>>>>>                         $dummy["postid"]        =
>> $item->getId();
>>>>>>
>>>>>>                         $blogInfo = $item->getBlogInfo();
>>>>>>
>>>>>> _______________________________________________
>>>>>> pLog-svn mailing list
>>>>>> pLog-svn at devel.lifetype.net
>>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>>
>>>>> _______________________________________________
>>>>> pLog-svn mailing list
>>>>> pLog-svn at devel.lifetype.net
>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>
>>>>
>>>> --
>>>> Paul Westbrook
>>>> paul at westbrooks.org
>>>> <http://www.westbrooks.org>
>>>>
>>>>
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>
>>
>> --
>> Paul Westbrook
>> paul at westbrooks.org
>> <http://www.westbrooks.org>
>>
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>



More information about the pLog-svn mailing list