[pLog-svn] r4071 - in plog/branches/lifetype-1.1.1/class: data
test/tests/data
Jon Daley
plogworld at jon.limedaley.com
Sun Oct 1 20:55:05 GMT 2006
I don't quite understand a couple things:
we use domainize to change text that are domains? I don't think we should
do that. I added domainize, because we needed a more specific filter
instead of urlize. urlize should be called on the trailing portion of the
URL, and domainize on just the left.
I don't understand kouaa's comment about SEO and having _ in the
subdomains. Perhaps they count it as "duplicate" because they ignore
invalid URLs, which I guess is what he is trying to do, by using a _
instead of a -? Sounds kind of odd, but whatever, I guess.
What is wrong with a blog named "testblog.php"? Apache wouldn't
try to parse it would it?
I think your fix with the keeping the old blog name is a good one,
but not letting new blogs have an underscore in them. I guess if people
really wanted to generate domain names that cause problems with some
browsers, we could have a checkbox that says, "yes, I want to break
things", just seems like a bad idea to me.
On Sun, 1 Oct 2006, Oscar Renalias wrote:
> I really don't know, but I noticed somebody was having problem with this:
>
> http://bugs.lifetype.net/view.php?id=1076
>
> Also since this is used to generate nicer URLs even if subdomains are
> disabled, this could potentially lead to blog names like "testblog.php"
> whose URL would be:
>
> http://www.site.com/blog/testblog.php
>
> I guess that wouldn't quite work if we allow dots to be part of
> url-ized/domain-ized blog names.
>
> On 1 Oct 2006, at 23:42, Jon Daley wrote:
>
>> I purposely kept that in. Presumably that could be okay, couldn't it?
>> Normal wildcard DNS records allow those sorts of domains.
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
--
Jon Daley
http://jon.limedaley.com/
If you obey all the rules, you miss all the fun.
-- Katharine Hepburn
More information about the pLog-svn
mailing list