[pLog-svn] r4361 - in plog/trunk: class/action class/action/admin templates/admin templates/standard

[Reto Hugi]

On Wed, November 29, 2006 0:42, Jon Daley said:

>  	I think this way is better than before.  If is modifying their
> template, they will have to find the commentform.template and will realize
> that the current code is not pointing to their current directory.
>  	Maybe we will end up having lots of people complaining about it,
> but I think more people complain about the current method.

hmmm, what are they complaining about with the way it is?

>> maybe, but I don't think this one changes a lot. Your commit broke quite
>> a few templates, though, I suppose...
>  	I don't understand.  What broke?

Not all templates used the same markup in the commentform.template. I did
not do a "visual" check, but I'm sure there are some that are now broken.
And I already saw other things we need to check. the "ice" template still
links to a local commentform, that isn't there anymore...

It wouldn't be the badest idea to have something like a "default" template
(maybe the standard template could be the basis for it). All other
templates would usually "use" the markup of the "default" template and
only if they need different markup for footer or header, they link to
template files in its own template folder.

this would encourage the following things (imo):
- proper and valid markup for all templates almost out of the box
- focus on css for design
- template maintainers wouldn't have to worry too much about compatibility
with new versions (because we maintain the "default"
- adding other plugins (not only in commentform.template, but also
postandcomments etc.) would be much easier! (we could already have the top
xx plugins included, so there is no need to do anything in the templates.
plugins would truly work out of the box)

things to concider:
- we can change to that behaviour and still be backward compliant!!!
- we cannot do this change for all templates as this would be a horrible
lot of work. it's more of a framework for future templates and template
maintainers which are interested in porting their template themselves
- we should create a folder called "default" or similar for these template
files. I don't think /misc/ is where we should put it.

I'm curious about your opinions...

reto