[pLog-svn] Trackbacks with 1.1.1

[Oscar Renalias]

BaseRequestGenerator::postLink() returns a valid URL but it isn't  
doing any escaping if needed.

The other problem is that I can't unfortunately remember what the  
purpose of that call to str_replace was...

On 1 Nov 2006, at 20:51, Reto Hugi wrote:

> On 01.11.2006 19:01, Oscar Renalias wrote:
>
>> This code is from class/dao/trackbackclient.class.php. Isn't the code
>> above doing what you just said?
>>
>
> In baserequestgenerator::postTrackbackLink we are doing this:
>
> $postLink = str_replace('-', '%2D', $this->postLink($post));
>
> and the dc reference for "identifier" says:
> "Recommended best practice is to identify the resource by means of a
> string or number conforming to a formal identification system. Formal
> identification systems include but are not limited to the Uniform
> Resource Identifier (URI) (including the Uniform Resource Locator
> (URL)), the Digital Object Identifier (DOI) and the International
> Standard Book Number (ISBN)."
>
> I can fix this bug for my scenario by doing this in the above  
> mentioned
> function:
> //$postLink = str_replace('-', '%2D', $this->postLink($post));
> $postLink = $this->postLink($post);
>
> IMO $this->postLink($post)) should return a valid url, so there is no
> need to do this str_replace stuff, right?
>
> reto
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>