[pLog-svn] r3486 - plog/trunk/class/database/pdb/drivers

[Jon Daley]

 	Ah, my fault.  Next checkin should fix that warning.  I think your 
@ sign should be taken out, and we fix all callers that cause that 
warning; I don't think there is ever a good reason for a warning to appear 
on a Close() call.

On Mon, 29 May 2006, Mark Wu wrote:

> Line 1375 of wizard.php
>
> Mark
>
>> -----Original Message-----
>> From: plog-svn-bounces at devel.lifetype.net
>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>> Sent: Monday, May 29, 2006 7:58 PM
>> To: plog-svn at devel.lifetype.net
>> Subject: RE: [pLog-svn] r3486 - plog/trunk/class/database/pdb/drivers
>>
>>  	line 1375 of what file?  If you mean pdbmysqlrecordset,
>> I understand that, I want to know who the caller is.
>>
>> On Mon, 29 May 2006, Mark Wu wrote:
>>
>>> Actually, the warning there is right. And the code is okay, too.
>>>
>>> I guess it is because the result set is empty, that's why
>> show this message.
>>>
>>> The line is 1375.
>>>
>>> Mark
>>>
>>>> -----Original Message-----
>>>> From: plog-svn-bounces at devel.lifetype.net
>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>>>> Sent: Monday, May 29, 2006 7:51 PM
>>>> To: plog-svn at devel.lifetype.net
>>>> Subject: Re: [pLog-svn] r3486 -
>> plog/trunk/class/database/pdb/drivers
>>>>
>>>>  	Where were the warnings occurring?  That probably means I was
>>>> calling Close in the wrong place, and the call should be removed.
>>>> Close's are only appropriate on some operations.
>>>>
>>>>   On Mon, 29 May 2006, mark at devel.lifetype.net wrote:
>>>>
>>>>> Author: mark
>>>>> Date: 2006-05-29 06:41:54 +0000 (Mon, 29 May 2006) New
>>>> Revision: 3486
>>>>>
>>>>> Modified:
>>>>>
>> plog/trunk/class/database/pdb/drivers/pdbmysqlrecordset.class.php
>>>>> Log:
>>>>> Add @ in front of mysql_free_results to aviod warnings ...
>>>>>
>>>>> Modified:
>>>>> plog/trunk/class/database/pdb/drivers/pdbmysqlrecordset.class.php
>>>>>
>> ===================================================================
>>>>> ---
>>>> plog/trunk/class/database/pdb/drivers/pdbmysqlrecordset.cl
>>>> ass.php	2006-05-29 06:33:11 UTC (rev 3485)
>>>>> +++
>>>> plog/trunk/class/database/pdb/drivers/pdbmysqlrecordset.cl
>>>> ass.php	2006-05-29 06:41:54 UTC (rev 3486)
>>>>> @@ -1,39 +1,39 @@
>>>>> -<?php
>>>>> -
>>>>> -	include_once(
>>>>
>> PLOG_CLASS_PATH."class/database/pdb/drivers/pdbrecordset.class.php"
>>>> );
>>>>> +<?php
>>>>>
>>>>> +	include_once(
>>>>>
>>>>
>> +PLOG_CLASS_PATH."class/database/pdb/drivers/pdbrecordset.class.php"
>>>>> +);
>>>>> +
>>>>>     /**
>>>>>      * \ingroup PDb
>>>>>      *
>>>>>      * MySQL record sets.
>>>>>      *
>>>>>      * @see PDbRecordSet
>>>>> -     */
>>>>> -	class PdbMySQLRecordSet extends PdbRecordSet
>>>>> -	{
>>>>> +     */
>>>>> +	class PdbMySQLRecordSet extends PdbRecordSet
>>>>> +	{
>>>>>
>>>>> 	    /**
>>>>> 	     * @see PDbRecordSet
>>>>> -	     */
>>>>> -		function PdbMySQLRecordSet( $dbRes = null )
>>>>> -		{
>>>>> -			$this->PdbRecordSet( $dbRes );
>>>>> -		}
>>>>> +	     */
>>>>> +		function PdbMySQLRecordSet( $dbRes = null )
>>>>> +		{
>>>>> +			$this->PdbRecordSet( $dbRes );
>>>>> +		}
>>>>>
>>>>> 	    /**
>>>>> 	     * @see PDbRecordSet::FetchRow()
>>>>> -	     */
>>>>> -		function FetchRow()
>>>>> -		{
>>>>> -			return( mysql_fetch_assoc( $this->_dbRes ));
>>>>> -		}
>>>>> +	     */
>>>>> +		function FetchRow()
>>>>> +		{
>>>>> +			return( mysql_fetch_assoc( $this->_dbRes ));
>>>>> +		}
>>>>>
>>>>> 	    /**
>>>>> 	     * @see PDbRecordSet::RecordCount()
>>>>> -	     */
>>>>> -		function RecordCount()
>>>>> -		{
>>>>> -			return( mysql_num_rows( $this->_dbRes ));
>>>>> +	     */
>>>>> +		function RecordCount()
>>>>> +		{
>>>>> +			return( mysql_num_rows( $this->_dbRes ));
>>>>> 		}
>>>>>
>>>>> 	    /**
>>>>> @@ -41,7 +41,7 @@
>>>>> 	     */
>>>>> 		function Close()
>>>>> 		{
>>>>> -		    return( mysql_free_result( $this->_dbRes ));
>>>>> -		}
>>>>> -	}
>>>>> +		    return( @mysql_free_result( $this->_dbRes ));
>>>>> +		}
>>>>> +	}
>>>>> ?>
>>>>> \ No newline at end of file
>>>>>
>>>>> _______________________________________________
>>>>> pLog-svn mailing list
>>>>> pLog-svn at devel.lifetype.net
>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>
>>>>
>>>> **************************************
>>>> Jon Daley
>>>> http://jon.limedaley.com/
>>>>
>>>> There is no mechanical problem so difficult that it cannot
>> be solved
>>>> by brute strength and ignorance.
>>>> -- William's Law
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>
>>
>> **************************************
>> Jon Daley
>> http://jon.limedaley.com/
>>
>> The real world is
>> a special case.
>> -- Horngren's Observation
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>

**************************************
Jon Daley
http://jon.limedaley.com/

Law breakers should trip when there's too much law flowing
-- Steve Mann