[pLog-svn] r3151 - plog/trunk/class/dao

[Mark Wu]

Hi Jon:

You are right. It is just like what you said, the variable is set with null
object.

Mark

> -----Original Message-----
> From: plog-svn-bounces at devel.lifetype.net 
> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
> Sent: Thursday, March 30, 2006 1:20 AM
> To: plog-svn at devel.lifetype.net
> Subject: Re: [pLog-svn] r3151 - plog/trunk/class/dao
> 
>  	Perhaps the failing case was when the _cache->getData 
> returned something, so the variable was set, but not a real object?
> 
> On Wed, 29 Mar 2006, oscar at devel.lifetype.net wrote:
> 
> > Author: oscar
> > Date: 2006-03-29 16:46:12 +0000 (Wed, 29 Mar 2006) New 
> Revision: 3151
> >
> > Modified:
> >   plog/trunk/class/dao/model.class.php
> > Log:
> > Mark's change 3149 broke many things and I didn't quite 
> understand it. 
> > If all we wanted is to get rid of the warning, probably 
> something like I've done is enough... The php parser is just 
> whining that the variable wasn't defined anywhere, so let's 
> define it with a harmless value.
> >
> >
> > Modified: plog/trunk/class/dao/model.class.php
> > ===================================================================
> > --- plog/trunk/class/dao/model.class.php	2006-03-29 
> 16:33:02 UTC (rev 3150)
> > +++ plog/trunk/class/dao/model.class.php	2006-03-29 
> 16:46:12 UTC (rev 3151)
> > @@ -280,8 +280,10 @@
> > 			// if we previously used the search 
> terms, then we did not cache the data
> > 			if( $searchTerms == "" )
> > 				$dbObjects = 
> $this->_cache->getData( $value, $cacheId );
> > +			else
> > +				$dbObjects = null;
> >
> > -        	if( !isset( $dbObjects ) ) {
> > +        	if( !$dbObjects ) {
> >         		$this->log->debug("getMany: $key:$value 
> - cache = $cacheId -- cache miss!");
> >         		$query = "SELECT * FROM ".$this->table;
> > 				$where = "";
> >
> > _______________________________________________
> > pLog-svn mailing list
> > pLog-svn at devel.lifetype.net
> > http://devel.lifetype.net/mailman/listinfo/plog-svn
> >
> 
> **************************************
> Jon Daley
> http://jon.limedaley.com/
> 
> I haven't lost my mind; I have a tape backup somewhere.
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn