[pLog-svn] r3149 - plog/trunk/class/dao

[Jon Daley]

 	Hrm, now I am more confused.  Did you appropriately put (and omit) 
'!' in your message?
 	if($dbojects) should never be replaced by if(!isset($dbobjects)) 
right?

On Wed, 29 Mar 2006, Mark Wu wrote:
> Yep..
>
> In model.class.php, there are two place use if ($dbobject). Acutally, one is
> if ($dbobjects) and the other is  if ($dbobject) .....
>
> And seems only "if ($dbobjects)" should change to if (!isset($dbobjects))
> ...
>
> I'll check the code again ...
>
> Mark
>
>> -----Original Message-----
>> From: plog-svn-bounces at devel.lifetype.net
>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>> Sent: Wednesday, March 29, 2006 8:26 PM
>> To: plog-svn at devel.lifetype.net
>> Subject: Re: [pLog-svn] r3149 - plog/trunk/class/dao
>>
>>  	I am not sure what this means.  Do you mean
>> if($asd) needs to be changed to if(isset($asd)) but if(!$asd) is okay?
>>
>>
>> On Wed, 29 Mar 2006, mark at devel.lifetype.net wrote:
>>> Author: mark
>>> Date: 2006-03-29 12:02:45 +0000 (Wed, 29 Mar 2006) New
>> Revision: 3149
>>>
>>> Modified:
>>>   plog/trunk/class/dao/model.class.php
>>> Log:
>>> revert some code of the last modification. Seems only
>> if($dbobjects) need to modify, and if($dbobject) doesn't need
>> any modification.
>>>
>>> Modified: plog/trunk/class/dao/model.class.php
>>> ===================================================================
>>> --- plog/trunk/class/dao/model.class.php	2006-03-29
>> 11:40:19 UTC (rev 3148)
>>> +++ plog/trunk/class/dao/model.class.php	2006-03-29
>> 12:02:45 UTC (rev 3149)
>>> @@ -170,7 +170,7 @@
>>>         {
>>>         	$dbObject = $this->_cache->getData( $value, $cacheId );
>>>
>>> -        	if( !isset( $dbObject ) ) {
>>> +        	if( !$dbObject ) {
>>> 	        	$this->log->debug("get: $field:$value -
>> cache = $cacheId" );
>>> 	        	$query = "SELECT * FROM
>> ".$this->table." WHERE {$field} =
>>> '".Db::qstr( $value )."'";
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>

**************************************
Jon Daley
http://jon.limedaley.com/

Common sense is not so common.
-- Voltaire