[pLog-svn] r3125 - plog/trunk/class/action/admin

jondaley at devel.lifetype.net jondaley at devel.lifetype.net
Sat Mar 25 16:57:54 GMT 2006


Author: jondaley
Date: 2006-03-25 16:57:53 +0000 (Sat, 25 Mar 2006)
New Revision: 3125

Modified:
   plog/trunk/class/action/admin/admindeletetrackbackaction.class.php
Log:
if article doesn't exist, delete trackback without checking permissions.  I don't think this is a security risk, since it shouldn't ever happen, and might as well let any user delete a mislinked trackback, than force it to be manually deleted through the database

Modified: plog/trunk/class/action/admin/admindeletetrackbackaction.class.php
===================================================================
--- plog/trunk/class/action/admin/admindeletetrackbackaction.class.php	2006-03-25 16:09:37 UTC (rev 3124)
+++ plog/trunk/class/action/admin/admindeletetrackbackaction.class.php	2006-03-25 16:57:53 UTC (rev 3125)
@@ -101,7 +101,7 @@
 					
 					// check if the trackback really belongs to this blog...
 					$article = $trackback->getArticle();
-					if( !$article || ($article->getBlogId() != $this->_blogInfo->getId())) {
+					if( $article && ($article->getBlogId() != $this->_blogInfo->getId())) {
 						// if not, then we shouldn't be allowed to remove anything!						
 						$errorMessage .= $this->_locale->pr("error_deleting_trackback", $trackback->getExcerpt())."<br/>";
 					}



More information about the pLog-svn mailing list