[pLog-svn] r3799 - plog/trunk/config

Jon Daley plogworld at jon.limedaley.com
Wed Jul 26 04:28:29 GMT 2006


 	So, the problem is fixed now (pending Mark's approval), but I 
wonder if this is the right way to go about this problem.
 	What if we just included the file, and merged it with our data, 
and then wrote the array back out.  The problem with this is that the 
configfilestorage would have to make to not put in extra $config stuff 
that wasn't already there, but maybe we could unset($config) or something.
 	Then there aren't any regular expressions to parse this file.

 	I guess since it works, it doesn't need to be changed.

On Tue, 25 Jul 2006, Jon Daley wrote:

> 	Ok, I understand now.  We should probably rewrite _getDataString to 
> understand either.  Or even better, not read it at all, but just include() 
> it, and then write the file.
>
> On Wed, 26 Jul 2006, Mark Wu wrote:
>
>> Writing....
>> 
>> There are two scenario:
>> 
>> 1. After you install, then you change the double  quote to single quote, it
>> will be fine. Because we read the config value from global variables.
>> 
>> 2. When you write the value to config file. We have to parse(reading) it
>> first ... See "_getDataString", then write the value ...
>> 
>> The problem happened in _getDataString, it can not parse the value quote
>> with single quote.
>> 
>> Mark
>> 
>>> -----Original Message-----
>>> From: plog-svn-bounces at devel.lifetype.net
>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>>> Sent: Wednesday, July 26, 2006 2:07 AM
>>> To: plog-svn at devel.lifetype.net
>>> Subject: RE: [pLog-svn] r3799 - plog/trunk/config
>>>
>>>  	Reading it, or writing?
>>> 
>>> On Wed, 26 Jul 2006, Mark Wu wrote:
>>> 
>>>> We use regexp to get the value string, and it hard coded
>>> with double quote.
>>>> So, when you change to single quote, the problem occurs ...
>>>> 
>>>> Mark
>>>> 
>>>>> -----Original Message-----
>>>>> From: plog-svn-bounces at devel.lifetype.net
>>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of Jon Daley
>>>>> Sent: Wednesday, July 26, 2006 1:55 AM
>>>>> To: plog-svn at devel.lifetype.net
>>>>> Subject: RE: [pLog-svn] r3799 - plog/trunk/config
>>>>>
>>>>>  	Ah, it is a problem when it goes to write the config file?  I
>>>>> hadn't tested that part, the original bug was when upgrading.
>>>>>  	It seems like it shouldn't be that hard to change the
>>>>> configfilestorage, is it?  I haven't looked at that code before.
>>>>> 
>>>>> On Wed, 26 Jul 2006, Mark Wu wrote:
>>>>> 
>>>>>> Hi Jon:
>>>>>> 
>>>>>> No error message when you in step2, but there is a error
>>> message in
>>>>>> step 3 when we click "next"
>>>>>> 
>>>>>> ======
>>>>>> Access denied for user 'ODBC'@'localhost' (using password: NO) in
>>>>>> 
>>>>> 
>>> D:\WWW\LifeType\1.1\class\database\pdb\drivers\pdbmysqldriver.class.p
>>>>> h
>>>>>> p on line 74 ======
>>>>>> 
>>>>>> After I check the config.properties, I found no value add
>>>>> to this file
>>>>>> :( That's why cause this error.
>>>>>> 
>>>>>> After I revet it back to double quote, the problem sovled.
>>>>>> 
>>>>>> This bug confirm in windowsxp/php5.1.2 and debian/php4.4.2
>>>>> (I only try
>>>>>> this two environment)
>>>>>> 
>>>>>> Also confirm with the other two moderators in Chinese forum.
>>>>>> 
>>>>>> ** I think we should release a new beta 1 ASAP, or it
>>> will become a
>>>>>> big problem in forum. I guess.
>>>>>> 
>>>>>> Mark
>>>>>> 
>>>>>>> -----Original Message-----
>>>>>>> From: plog-svn-bounces at devel.lifetype.net
>>>>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf
>>> Of Jon Daley
>>>>>>> Sent: Wednesday, July 26, 2006 1:37 AM
>>>>>>> To: plog-svn at devel.lifetype.net
>>>>>>> Subject: RE: [pLog-svn] r3799 - plog/trunk/config
>>>>>>>
>>>>>>>  	What error do you get?   Yes, it worked fine for me.
>>>>>>> 
>>>>>>> On Wed, 26 Jul 2006, Mark Wu wrote:
>>>>>>> 
>>>>>>>> Hi Jon:
>>>>>>>> 
>>>>>>>> Does your 3768 change work in linux env? It seems not work
>>>>>>> in Windows.
>>>>>>>> :(
>>>>>>>> 
>>>>>>>> Hi Oscar:
>>>>>>>> 
>>>>>>>> I think we have to replace this file in current beta1, or
>>>>>>> the windows
>>>>>>>> user can not install lifetype using installation wizard.
>>>>>>>> 
>>>>>>>> Mark
>>>>>>>> 
>>>>>>>>> -----Original Message-----
>>>>>>>>> From: plog-svn-bounces at devel.lifetype.net
>>>>>>>>> [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
>>>>>>>>> mark at devel.lifetype.net
>>>>>>>>> Sent: Wednesday, July 26, 2006 12:32 AM
>>>>>>>>> To: plog-svn at devel.lifetype.net
>>>>>>>>> Subject: [pLog-svn] r3799 - plog/trunk/config
>>>>>>>>> 
>>>>>>>>> Author: mark
>>>>>>>>> Date: 2006-07-25 16:32:02 +0000 (Tue, 25 Jul 2006) New
>>>>>>> Revision: 3799
>>>>>>>>> 
>>>>>>>>> Modified:
>>>>>>>>>    plog/trunk/config/config.properties.php
>>>>>>>>> Log:
>>>>>>>>> Revert Jon's 3768 changes. It will break installation wizard.
>>>>>>>>> 
>>>>>>>>> If we want to use single quote, we need to change the
>>>>>>>>> confgifilestorage.class.php, too.
>>>>>>>>> 
>>>>>>>>> Modified: plog/trunk/config/config.properties.php
>>>>>>>>> 
>>>>> ===================================================================
>>>>>>>>> --- plog/trunk/config/config.properties.php	2006-07-25
>>>>>>>>> 15:39:37 UTC (rev 3798)
>>>>>>>>> +++ plog/trunk/config/config.properties.php	2006-07-25
>>>>>>>>> 16:32:02 UTC (rev 3799)
>>>>>>>>> @@ -26,11 +26,11 @@
>>>>>>>>>  #   (note, if upgrading between minor releases:
>>>>>>>>>  #   1.0 to 1.0.1, etc. you shouldn't run the wizard)
>>>>>>>>> 
>>>>>>>>> -$config["db_host"] = '';
>>>>>>>>> -$config["db_username"] = '';
>>>>>>>>> -$config["db_password"] = '';
>>>>>>>>> -$config["db_database"] = '';
>>>>>>>>> -$config["db_prefix"] = '';
>>>>>>>>> -$config["db_character_set"] = 'default';
>>>>>>>>> +$config["db_host"] = "";
>>>>>>>>> +$config["db_username"] = "";
>>>>>>>>> +$config["db_password"] = "";
>>>>>>>>> +$config["db_database"] = "";
>>>>>>>>> +$config["db_prefix"] = "";
>>>>>>>>> +$config["db_character_set"] = "default";
>>>>>>>>>  $config["db_persistent"] = true;  ?> \ No newline at
>>> end of file
>>>>>>>>> 
>>>>>>>>> _______________________________________________
>>>>>>>>> pLog-svn mailing list
>>>>>>>>> pLog-svn at devel.lifetype.net
>>>>>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>>>> 
>>>>>>>> _______________________________________________
>>>>>>>> pLog-svn mailing list
>>>>>>>> pLog-svn at devel.lifetype.net
>>>>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> Jon Daley
>>>>>>> http://jon.limedaley.com/
>>>>>>> 
>>>>>>> Teacher: What says 'A'?
>>>>>>> Student: A Canadian.
>>>>>>> -- based on a thought by Steve Moore
>>>>>>> _______________________________________________
>>>>>>> pLog-svn mailing list
>>>>>>> pLog-svn at devel.lifetype.net
>>>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>> 
>>>>>> _______________________________________________
>>>>>> pLog-svn mailing list
>>>>>> pLog-svn at devel.lifetype.net
>>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>>>> 
>>>>> 
>>>>> --
>>>>> Jon Daley
>>>>> http://jon.limedaley.com/
>>>>> 
>>>>> A professor is one who can speak on any subject: for
>>> precisely fifty
>>>>> minutes.
>>>>> -- Norbert Weiner
>>>>> _______________________________________________
>>>>> pLog-svn mailing list
>>>>> pLog-svn at devel.lifetype.net
>>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>> 
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.lifetype.net
>>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>>>> 
>>> 
>>> --
>>> Jon Daley
>>> http://jon.limedaley.com/
>>> 
>>> So, on Wednesday, we will go into more depth in this...
>>>    or at least repeat it.
>>> -- Dr. Langevin
>>> _______________________________________________
>>> pLog-svn mailing list
>>> pLog-svn at devel.lifetype.net
>>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>> 
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>> 
>
> -- 
> Jon Daley
> http://jon.limedaley.com/
>
> If you want to make enemies, try to change something.
> -- Woodrow Wilson
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>

-- 
Jon Daley
http://jon.limedaley.com/

Dyslexics of the world, untie!


More information about the pLog-svn mailing list