[pLog-svn] r3691 - plog/trunk/class/net

oscar at devel.lifetype.net oscar at devel.lifetype.net
Wed Jul 5 14:41:07 GMT 2006


Author: oscar
Date: 2006-07-05 14:41:07 +0000 (Wed, 05 Jul 2006)
New Revision: 3691

Modified:
   plog/trunk/class/net/url.class.php
Log:
removed an 'evil' eval (funny how the difference between 'evil' and 'eval' is only one letter :))


Modified: plog/trunk/class/net/url.class.php
===================================================================
--- plog/trunk/class/net/url.class.php	2006-07-05 14:38:39 UTC (rev 3690)
+++ plog/trunk/class/net/url.class.php	2006-07-05 14:41:07 UTC (rev 3691)
@@ -44,8 +44,6 @@
 		 */
 		function Url( $url )
 		{
-			
-
 			$this->_url = $url;
 
 			$this->_calculateFields();
@@ -64,8 +62,8 @@
 			// this saves us time ;)
 			foreach( $keys as $key ) {
                 if (isset($parts[$key])) {
-                    $line = "\$this->_$key = \$parts[\"$key\"];";	
-                    eval($line);
+					$var = "_{$key}";
+					$this->$var = $parts["$key"];
                 }
 			}
 		}



More information about the pLog-svn mailing list