[pLog-svn] r4375 - in plugins/branches/lifetype-1.1/editcomments: . class/action class/view locale templates

[Jon Daley]

On Sun, 3 Dec 2006, reto at devel.lifetype.net wrote:
> @jon: if you think we shouldn't add this feature to the editcomments 
> plugin, I'll of course create an editTrackback plugin.
 	That's fine.  I actually thought of that the other day, but I 
don't do much with trackbacks, so it wasn't on my list to do.

> btw: can you explain why you do this on line 41 of adminupdatecommentaction
> $view = new AdminEditCommentView($this->_blogInfo, $commentId);
 	Probably not.  I copy a lot of code to do this stuff, I don't have 
a good grasp of the views and validation yet.

> a) why do we need that new view there?
 	I think it is only for when there is an error.  What is the right 
way to display a validation error?

> b) $commentId will never be a value right there, right?
 	Yes, I see that.  I had re-ordered that function a couple times, 
and probably that was down lower before, but got moved.  I think I tested 
the error case, so probably that means it isn't really needed.  I probably 
won't have time to fix it, so it would be great if you could.