[pLog-svn] Email Validator

Jon Daley plogworld at jon.limedaley.com
Mon Aug 21 00:47:56 GMT 2006


A domain with just numbers is being marked as wrong.

See: http://bugs.lifetype.net/view.php?id=1022

There is one [a-z] check in the #5 check.  Is that supposed to be there, 
can you (Ammar) remove it?  I am not quite sure how that regexp is working 
currently, so I am not sure about changing it.  Was the test case written 
yet Mark?


On Sun, 23 Jul 2006, Ammar Ibrahim wrote:

> That's exactly what I did, it's a crazy regex! And the good thing all the
> good adresses are passing, but some invalid adresses like ammar at h.a are
> passing although no domain is one letter and no tld is one letter. but I
> think this should be OK, anyhow, if you think we need something more serious
> I can get the RFC one.
>
> On 7/23/06, Jon Daley <plogworld at jon.limedaley.com> wrote:
>>
>>         There's a pretty crazy regexp.  How much did you test it?  I don't
>> want to actually go through a read it, but if you have tested it with a
>> half dozen addresses, good and bad, and it caught them correctly, that is
>> good enough for me.
>> 
>> On Sun, 23 Jul 2006, Ammar Ibrahim wrote:
>> 
>> > find the new code attached for your review. I didn't go for the full RFC
>> > validation.
>> >
>> > - Ammar
>> >
>> 
>> --
>> Jon Daley
>> http://jon.limedaley.com/
>> 
>> Everything takes longer than you think.
>> -- Murphy's Second Law
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.lifetype.net
>> http://devel.lifetype.net/mailman/listinfo/plog-svn
>> 
>

-- 
Jon Daley
http://jon.limedaley.com/

Normal people believe that if it ain't broke,
    don't fix it.
Engineers believe that if it ain't broke,
    it doesn't have enough features yet.


More information about the pLog-svn mailing list