[pLog-svn] r3191 - plog/trunk/install

Oscar Renalias oscar at renalias.net
Wed Apr 5 13:19:18 GMT 2006


That could work, I guess.

Oscar

On 4/5/06, Mark Wu <markplace at gmail.com> wrote:
> Wow... Man...
>
> I didn't notice this!!! In wizard.php line 1213:
>
> $newSettings = range( 114, 119 );
>
> I think I have to fix this , right?
>
> How about we change the key to
>
> $Inserts[$i++][$version] = "xxxx";
>
> Then, we can check to version to decide we want to insert the new setting or
> not...
>
> Maybe it will be eaiser..
>
> Any thoughts?
>
> Mark
>
> > -----Original Message-----
> > From: plog-svn-bounces at devel.lifetype.net
> > [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
> > Oscar Renalias
> > Sent: Wednesday, April 05, 2006 9:04 PM
> > To: plog-svn at devel.lifetype.net
> > Subject: Re: [pLog-svn] r3191 - plog/trunk/install
> >
> > I had been considering using the key as the index. The only
> > reason I can think why the key was an integer so far is
> > because there is a part in the index that needs to know which
> > indexes need to be added as new for the current release so I
> > did something like
> >
> > $configKeys = range( 76, 119 );
> > ...
> >
> > and then add the keys with the generated indexes while now we
> > have to manually specify all the new keys in an array. But I
> > do agree that it should be easier to maintain now.
> >
> > Oscar
> >
> > On 4/5/06, Mark Wu <markplace at gmail.com> wrote:
> > > Hi Jon:
> > >
> > > I think use  config_key  is okay, too. According to eh
> > wizard, it use
> > > foreach() to read the insert queries one by one ... So, it
> > should be okay..
> > >
> > > And, I already check is there any duplicated key or not... The
> > > duplicate key already removed ...:D
> > >
> > > Mark
> > >
> > > > -----Original Message-----
> > > > From: plog-svn-bounces at devel.lifetype.net
> > > > [mailto:plog-svn-bounces at devel.lifetype.net] On Behalf Of
> > Jon Daley
> > > > Sent: Wednesday, April 05, 2006 8:37 PM
> > > > To: plog-svn at devel.lifetype.net
> > > > Subject: Re: [pLog-svn] r3191 - plog/trunk/install
> > > >
> > > >       I had been wondering about this table.  Occasionally I am
> > > > working on someone's lifetype install where they have duplicate
> > > > entries in the table.  I am not sure how it happens, but
> > if we made
> > > > the config_key the index, rather than an integer, we
> > wouldn't have
> > > > this problem.
> > > >       Is there any reason for the extra unused integer?
> > > >
> > > > On Wed, 5 Apr 2006, mark at devel.lifetype.net wrote:
> > > > > Modified:
> > > > >   plog/trunk/install/defaultconfig.properties.php
> > > > > Log:
> > > > > Add a new insert query counter. Now we can insert any
> > > > predefined queries without worry about re-define the array index.
> > > > _______________________________________________
> > > > pLog-svn mailing list
> > > > pLog-svn at devel.lifetype.net
> > > > http://devel.lifetype.net/mailman/listinfo/plog-svn
> > >
> > > _______________________________________________
> > > pLog-svn mailing list
> > > pLog-svn at devel.lifetype.net
> > > http://devel.lifetype.net/mailman/listinfo/plog-svn
> > >
> > _______________________________________________
> > pLog-svn mailing list
> > pLog-svn at devel.lifetype.net
> > http://devel.lifetype.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.lifetype.net
> http://devel.lifetype.net/mailman/listinfo/plog-svn
>


More information about the pLog-svn mailing list