[pLog-svn] r2590 - plog/branches/plog-1.0.2/class/dao/

[Mark Wu]

Hi Jon:

I just find this change will casue the admin/blog page only show the
category with articles... If the category with articles, then the category
won't show.... :(

That means If there is ZERO articles in category, then you can not add this
where statement

"AND a.status = POST_STATUS_PUBLISHED"

Mark 

-----Original Message-----
From: plog-svn-bounces at devel.plogworld.net
[mailto:plog-svn-bounces at devel.plogworld.net] On Behalf Of Oscar Renalias
Sent: Tuesday, November 15, 2005 2:29 PM
To: plog-svn at devel.lifetype.net
Subject: Re: [pLog-svn] r2590 - plog/branches/plog-1.0.2/class/dao/

I forgot to add devel.lifetype.net to the DNS server, probably all our mail
servers were rejecting mail from a non-existing server.

I will review the change below, I can't remember now who's calling these
methods...

Oscar

On 11/14/05, Jon Daley <plogworld at jon.limedaley.com> wrote:
>         The svn list seems to be odd - maybe I need to change my 
> subversion repository to lifetype, instead of plogworld?
>
> Anyway, I made this change to getBlogCategories in 
> articlecategories.class.php
>
> - WHERE c.blog_id = '".Db::qstr($blogId)."'";
> + WHERE c.blog_id = '".Db::qstr($blogId)."' AND a.status = 
> + ".POST_STATUS_PUBLISHED;
>
>         Without this change, the category order functions check draft 
> posts, etc.
>
>         There are a couple people who call this function, though I 
> think only one place should be calling it, and the others should be 
> calling getBlogCategoriesAdmin, does that sound correct?  In other 
> words, should admin pages be calling the non-admin version of this
function?
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
_______________________________________________
pLog-svn mailing list
pLog-svn at devel.plogworld.net
http://devel.plogworld.net/mailman/listinfo/plog-svn