[pLog-svn] r2542 - plog/branches/plog-1.0.2/class/action/admin

[Jon Daley]

 	The only system I tried it on is my system that ran a pre-1.0 
wizard, and then has been updated as I went along.
 	Was I right in guessing that the direct trackback part is your 
stuff?  That code should be all commented until 1.1, right?  The part I 
added to the regular trackbacks might not be necessary, but I figure it 
doesn't hurt anything.

On Wed, 9 Nov 2005, Mark Wu wrote:
> Hi Jon:
>
> It works with new installation.
>
> It seems Oscar remark the "direct trackback" field that I forgot remark....
> Sorry, I forgot remark this.
>
> Did you try new installation instead of  use upgrade?
>
> Mark
>
> -----Original Message-----
> From: plog-svn-bounces at devel.plogworld.net
> [mailto:plog-svn-bounces at devel.plogworld.net] On Behalf Of Jon Daley
> Sent: Wednesday, November 09, 2005 8:10 PM
> To: plog-svn at devel.plogworld.net
> Subject: Re: [pLog-svn] r2542 - plog/branches/plog-1.0.2/class/action/admin
>
> 	The rest of you use trackbacks, don't you?  Shouldn't you have seen
> this error too?
> 	I get a null array getting passed to the foreach loop in function
> sendDirectTrackbacks( $trackbacks, $article, $blogName ) (in
> dao/trackbackclient.class.php)
>
> On Wed, 9 Nov 2005, jondaley at devel.plogworld.net wrote:
>> Modified:
>>
>> plog/branches/plog-1.0.2/class/action/admin/adminsendtrackbacksaction.
>> class.php
>> Log:
>> I don't normally use trackbacks, but I get an error trying to send a
> trackback to lifetype's announcement page.  My off-the-wall guess is that
> this has something to do with Mark's new trackback stuff that Oscar made him
> remove until 1.1?
>>
>> Modified:
>> plog/branches/plog-1.0.2/class/action/admin/adminsendtrackbacksaction.
>> class.php
>> ===================================================================
>> ---
> plog/branches/plog-1.0.2/class/action/admin/adminsendtrackbacksaction.class.
> php	2005-11-07 13:32:47 UTC (rev 2541)
>> +++
> plog/branches/plog-1.0.2/class/action/admin/adminsendtrackbacksaction.class.
> php	2005-11-09 11:33:04 UTC (rev 2542)
>> @@ -76,7 +76,7 @@
>>             $postLinks = Array();
>>             $trackbackLinks = Array();
>>
>> -			if ( count($this->_postLinks) != 0 ) {
>> +			if ( $this->_postLinks && count($this->_postLinks)
> != 0 ) {
>> 	            $autoDiscoverResults = $tbClient->sendTrackbacks(
>> $this->_postLinks, $post, $this->_blogInfo);
>>
>> 	            foreach( $autoDiscoverResults as $result ) { @@ -95,7
>> +95,7 @@
>> 	            }
>> 	        }
>>
>> -			if ( count($this->_trackbackLinks) != 0 ) {
>> +			if ( $this->_trackbackLinks &&
> count($this->_trackbackLinks) != 0
>> +) {
>> 	            $directPingResults = $tbClient->sendDirectTrackbacks(
>> $this->_trackbackLinks, $post, $this->_blogInfo);
>>
>> 	            foreach( $directPingResults as $result ) { @@ -110,7
>> +110,7 @@
>> 	                }
>> 	            }
>> 			}
>> -
>> +
>>             // if there were errors, we let the user try again
>>             if( $errors ) {
>>             	if( $message != "" )
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.plogworld.net
>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>
>
> **************************************
> Jon Daley
> http://jon.limedaley.com/plog/
>
> Sometimes you can observe a lot by watching.
> -- Yogi Berra
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>

**************************************
Jon Daley
http://jon.limedaley.com/plog/

The first rule of intelligent tinkering is to save all the parts.
-- Ehrlich