[pLog-svn] r2038 - in plog/branches/plog-1.0.1: . class/summary/action

Oscar Renalias oscar at renalias.net
Sun May 22 17:48:19 GMT 2005


Ah sorry, I hadn't noticed this... since in your email you said "Set  
HTTP_ACCEPT_LANGUAGE_DETECTION to 1 to get the feature working!" I  
thought that this was the only way to enable the feature. But no  
worries, you did it the right way :)

The problem is that we are not going to modify the admin interface  
strings until 1.1, so we cannot really add anything to the "summary  
settings" page. The idea is to tell people to either enable the  
constant you created or run an SQL query to set  
"use_http_accept_language_detection" to 1 in the plog_config table if  
interested in this feature.

You can also make the changes to 1.1 right away if you wish. Just  
edit the "summary" settings page, add a new row for this, a new  
string with the help message and off we go. By the way, add any new  
strings at the bottom of the file so that we can know what's changed  
when updating the other translations based on the English one.

Sorry about this, looks like the dumb one is me :)))

Oscar

On 22 May 2005, at 20:30, Reto Hugi wrote:

> I'm not sure I really understood your requirements about the db- 
> upgrade
> and the possibility to activate it as a "hidden feature" until v1.1 is
> out, providing a radiobutton in the admin panel. So that's what I did:
>
> Added this and *only this* line to the wizard:
> $Inserts[113] = "INSERT INTO {dbprefix}config (config_key,  
> config_value,
> value_type) VALUES('use_http_accept_language_detection', '0', 1);
>
> -> default value is deactivated. It accepts 0 or 1.
>
> My intention was to add the config value as soon as the DB is upgraded
> to 1.1 - is that the way to do it?
>
> In the script itself the php define is just a "workaround" to have a
> comfort way to use the feature even without admin panel and no  
> upgraded DB:
> elseif ( $this->_config->getValue 
> ( "use_http_accept_language_detection",
> HTTP_ACCEPT_LANGUAGE_DETECTION) == 1 )
>
> there the script asks for the config value, if there is none, the one
> passed as a second parameter will be returned. As this value is  
> defined
> by HTTP_ACCEPT_LANGUAGE_DETECTION it's just a fallback for now, until
> there is a config value in the db.
>
> I may be too dumb to get the point. But I'd be glad to correct my
> mess...just don't now how at the moment :)
>
> reto
>
>
> On 22.05.2005 18:18, Oscar Renalias wrote:
>
>> aaah this looks very good :)
>>
>> But I was wondering... could it be possible to use a configuration
>> key instead of a PHP define? I mean, something coming from the
>> plog_config table, just to be consistent with all the other plog
>> features, you know :))
>>
>> Oscar
>>
>>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
>




More information about the pLog-svn mailing list