[pLog-svn] r1926 - plog/branches/plog-1.0.1/templates/admin

Oscar Renalias oscar at renalias.net
Mon May 2 20:09:17 GMT 2005


I think this looks good but unfortunately we cannot include it in  
plog 1.0.1 :(

I think I already mentioned in the past that bug-fix releases (such  
as 1.0.1) must not include any changes that require changes to the  
locale files. The idea behind this reasoning is that we are much more  
flexible to release any time we're ready than if we have to contact  
people to translate, and then wait for them to do the translation, etc.

Would you mind reverting these changes and moving them back to 1.1?

Thanks,

Oscar

On 2 May 2005, at 21:19, mark at devel.plogworld.net wrote:

> Author: mark
> Date: 2005-05-02 18:19:13 +0000 (Mon, 02 May 2005)
> New Revision: 1926
>
> Modified:
>    plog/branches/plog-1.0.1/templates/admin/newpost.template
> Log:
> I think bookmarklet under those checkbox looks better then under  
> postExtentedText.
>
> Modified: plog/branches/plog-1.0.1/templates/admin/newpost.template
> ===================================================================
> --- plog/branches/plog-1.0.1/templates/admin/newpost.template     
> 2005-05-02 17:32:39 UTC (rev 1925)
> +++ plog/branches/plog-1.0.1/templates/admin/newpost.template     
> 2005-05-02 18:19:13 UTC (rev 1926)
> @@ -86,14 +86,6 @@
>           {/if}
>         </div>
>
> -        <div class="field">
> -            <label for="bookmarklet">{$locale->tr("bookmarklet")}</ 
> label>
> -            <div class="formHelp">{$locale->tr("bookmarklet_help")} 
> </div>
> -            {$locale->tr("blogit_to_plog")}
> -            (<a href="javascript:location.href='{$url->getAdminUrl 
> ()}?op=newPost&postText='+encodeURIComponent 
> (document.selection.createRange().text)" onclick="window.alert 
> ('{$locale->tr("bookmarklet_help")}');">IE</a> /
> -            <a href="javascript:location.href='{$url->getAdminUrl 
> ()}?op=newPost&postText='+encodeURIComponent(window.getSelection 
> ())" onclick="window.alert('{$locale->tr 
> ("bookmarklet_help")}');">FF</a>)
> -        </div>
> -
>         <!-- text area custom fields -->
>        {include file="$admintemplatepath/ 
> newpost_customfields.template" type=2 fields=$customfields}
>     </div>
> @@ -163,7 +155,14 @@
>           <label for="sendPings">{$locale->tr 
> ("send_xmlrpc_pings_help")}</label>
>           {/if}
>        </div>
> -
> +
> +      <div class="field">
> +           <br /><label for="bookmarklet">{$locale->tr 
> ("bookmarklet")}</label>
> +           <div class="formHelp">{$locale->tr("bookmarklet_help")} 
> </div>
> +           <a href="javascript:location.href='{$url->getAdminUrl 
> ()}?op=newPost&postText='+encodeURIComponent 
> (document.selection.createRange().text)" onclick="window.alert 
> ('{$locale->tr("bookmarklet_help")}');">{$locale->tr 
> ("blogit_to_plog")}</a>{$locale->tr("for_ie")}<br />
> +           <a href="javascript:location.href='{$url->getAdminUrl 
> ()}?op=newPost&postText='+encodeURIComponent(window.getSelection 
> ())" onclick="window.alert('{$locale->tr("bookmarklet_help")}');"> 
> {$locale->tr("blogit_to_plog")}</a>{$locale->tr("for_ff")}
> +      </div>
> +
>        <!-- checkbox custom fields -->
>         {include file="$admintemplatepath/ 
> newpost_customfields.template" type=3 fields=$customfields}
>
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
>




More information about the pLog-svn mailing list