[pLog-svn] r2347 - plog/trunk/class/action
Paul Westbrook
paul at westbrooks.org
Tue Jul 19 17:22:52 GMT 2005
Hello,
So there was a partial merge? The call to getArticleIdFromName was
merged, but not the impelementation?
The change that I made did not add a new function. I just changed
the call to getArticleIdFromName to getBlogArticleByTitle that was
already implemented. I thought that the getArticleIdFromName function
was removed because it is not really needed because it can be
implemented with the getBlogArticleByTitle function.
--Paul
On Jul 19, 2005, at 8:50 AM, Jon Daley wrote:
> If you mean removed as compared to the 1.0.2 version, it wasn't
> removed, but was just never merged over yet. We just need to remember
> when it gets merged that we now have the same function with two names?
>
> On Tue, 19 Jul 2005 pwestbro at devel.plogworld.net wrote:
>
>> Author: pwestbro
>> Date: 2005-07-19 04:57:46 +0000 (Tue, 19 Jul 2005)
>> New Revision: 2347
>>
>> Modified:
>> plog/trunk/class/action/viewarticleaction.class.php
>> Log:
>> Fixed http://bugs.plogworld.net/view.php?id=651
>>
>> It looks like the getArticleIdFromName function was removed. I
>> changed the
>> call to getBlogArticleByTitle. If the removal of
>> getArticleIdFromName was
>> not intended, this call can be changed back.
>>
>>
>> Modified: plog/trunk/class/action/viewarticleaction.class.php
>> ===================================================================
>> --- plog/trunk/class/action/viewarticleaction.class.php 2005-07-18
>> 20:51:42 UTC (rev 2346)
>> +++ plog/trunk/class/action/viewarticleaction.class.php 2005-07-19
>> 04:57:46 UTC (rev 2347)
>> @@ -78,7 +78,12 @@
>> * updates the article referrers, given a slug
>> */
>> function _updateArticleReferrersByTitle($slug){
>> - $id = $this->articles->getArticleIdFromName($slug);
>> + $id = 0;
>> + $article = $this->articles->getBlogArticleByTitle($slug);
>> + if ( $article )
>> + {
>> + $id = $article->getId();
>> + }
>> // if the article isn't found, we will save a referrer to
>> // the main page, since $id will be 0.
>> $this->_updateArticleReferrersById($id);
>>
>> _______________________________________________
>> pLog-svn mailing list
>> pLog-svn at devel.plogworld.net
>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>
>
> **************************************************************
> * Jon Daley * Eagles may soar, but weasels *
> * * don't get sucked into jet *
> * http://jon.limedaley.com/ * engines. *
> **************************************************************
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
>
--
Paul Westbrook
paul at westbrooks.org
<http://www.westbrooks.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2367 bytes
Desc: not available
Url : http://www.plogworld.net/pipermail/plog-svn/attachments/20050719/286b7a0e/smime.bin
More information about the pLog-svn
mailing list