[pLog-svn] r2364 - plog/branches/plog-1.0.2/templates/admin
Jon Daley
plogworld at jon.limedaley.com
Mon Aug 29 13:05:38 GMT 2005
Ok, followed your path around a bit. I see that it currently is
not working on my build. I think what changed was I was playing with
controller.class.php when looking at the problem with the pipeline being
run twice and doing the wrong thing. (the conversation is in mantis)
There is a bug in controller where the action isn't being set
correctly, and I had fixed that in my local build in the process of
debugging that. But, I reverted my change, since the pipeline thing
appears to be a difficult problem, and I wasn't sure that my fix was going
to be included in the final solution.
But, I would be willing to bet that my change made the
deleteComment work appropriately. I will try to remember what change I
made, since I think the this->_mode should be correctly seen as
deleteComment, and it is not intuitive to have to use actions in a
roundabout way.
As for your last statement, I also had thought about changing the
REQUEST parameter, but I think that is a bad idea (hopefully PHP doesn't
allow you to do that...), but it is on the same path as what I took when I
got the action to be set appropriately when forwarding actions.
On Mon, 29 Aug 2005, Mark Wu wrote:
> I think I know the reason why I use array instead of integer!
>
> Just take a look at adminmainaction.class.php
>
> I use the parameter ['action'] to represent next action after blog select
> .....
>
> So, the url looks
> http://blog.markplace.net/admin.php?op=blogSelect&blogId=1&action=deleteComm
> ent&commentId=977&articleId=18
>
> You can see the parameters in $_REQUEST is like
> ['op']=blogSelect
> ['action']=deleteComment
> ['blogId']=1
> ['commentId']=977
> ['articleId']=18
>
> And, then you take a look at admindeletecomment.class.php
>
> You can see when pLog validate the request, it use ['op'] to check the
> action is deleteComment or deleteComments
>
> That's why I use deleteComments ... Because the if statements only check the
> mode is "deleteComment " or not. If not, it will go "deleteComments" ....
>
> I just wondering why you change to "deleteComment " and works in your
> environment. D
>
> ** Maybe I should change the $_REQUEST content
> ['op'] = ['action'];
> AdminController::setForwardAction( $this->_nextAction );
> ***
>
> After I redirect to next action ...
>
> Mark
>
>> -----Original Message-----
>> From: Mark Wu [mailto:markplace at gmail.com]
>> Sent: Monday, August 29, 2005 5:40 PM
>> To: 'Mark Wu'; 'plog-svn at devel.plogworld.net'
>> Subject: RE: [pLog-svn] r2364 -
>> plog/branches/plog-1.0.2/templates/admin
>>
>> Hi Jon:
>>
>> BTW, I tested in both windows and linux environment (with
>> full new installation). Can you try to check out the newest
>> 1.0.2 branch and it again?
>>
>> Mark
>>
>>> -----Original Message-----
>>> From: Mark Wu [mailto:markplace at gmail.com]
>>> Sent: Monday, August 29, 2005 5:30 PM
>>> To: 'plog-svn at devel.plogworld.net'
>>> Subject: RE: [pLog-svn] r2364 -
>>> plog/branches/plog-1.0.2/templates/admin
>>>
>>> Hi Jon:
>>>
>>> I tested!! This fixed doesn't work for me .... :(
>>>
>>> Mark
>>>
>>>> -----Original Message-----
>>>> From: plog-svn-bounces at devel.plogworld.net
>>>> [mailto:plog-svn-bounces at devel.plogworld.net] On Behalf
>> Of Jon Daley
>>>> Sent: Thursday, July 28, 2005 12:20 AM
>>>> To: plog-svn at devel.plogworld.net
>>>> Subject: RE: [pLog-svn] r2364 -
>>>> plog/branches/plog-1.0.2/templates/admin
>>>>
>>>> So, I guess I can ask the question the other way. Does
>>> my change
>>>> work for you? I didn't totally revert your change, so maybe the
>>>> combination of what you added with the blogSelect stuff, and my
>>>> removal of the arrays works? We don't really use the
>>> arrays, since we
>>>> are only erasing one item at a time.
>>>>
>>>> On Wed, 27 Jul 2005, Mark Wu wrote:
>>>>> Hi Jon:
>>>>>
>>>>> That's the strangest part. I test it with appserv (under
>>>> windows) and
>>>>> my virtual server(linux), both of these environment run
>>> very well.
>>>>>
>>>>> The registers_global is off in both site.
>>>>>
>>>>> Mark
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: plog-svn-bounces at devel.plogworld.net
>>>>>> [mailto:plog-svn-bounces at devel.plogworld.net] On Behalf Of
>>>> Jon Daley
>>>>>> Sent: Wednesday, July 27, 2005 11:22 PM
>>>>>> To: plog-svn at devel.plogworld.net
>>>>>> Subject: RE: [pLog-svn] r2364 -
>>>>>> plog/branches/plog-1.0.2/templates/admin
>>>>>>
>>>>>> Yes, it worked. This is using the old code, or
>>> did you change
>>>>>> something?
>>>>>> If this is just the old code, perhaps there is
>>> a difference of
>>>>>> register globals, or some other setting in php.ini?
>>>>>>
>>>>>> On Wed, 27 Jul 2005, Mark Wu wrote:
>>>>>>> Hi Jon:
>>>>>>>
>>>>>>> Can you test in dev.plogworld.org.tw? Try
>>>>>>>
>>>>>>> http://dev.plogworld.org.tw
>>>>>>> User: tinymce
>>>>>>> Pass: tinymce
>>>>>>>
>>>>>>> You can test the delete comments work or not?
>>>>>>>
>>>>>>> Mark
>>>>>>>
>>>>>>>> -----Original Message-----
>>>>>>>> From: plog-svn-bounces at devel.plogworld.net
>>>>>>>> [mailto:plog-svn-bounces at devel.plogworld.net] On Behalf Of
>>>>>> Jon Daley
>>>>>>>> Sent: Wednesday, July 27, 2005 9:01 PM
>>>>>>>> To: plog-svn at devel.plogworld.net
>>>>>>>> Subject: RE: [pLog-svn] r2364 -
>>>>>>>> plog/branches/plog-1.0.2/templates/admin
>>>>>>>>
>>>>>>>> On Wed, 27 Jul 2005, Mark Wu wrote:
>>>>>>>>> Yes, I did test it :D
>>>>>>>> (:
>>>>>>>>
>>>>>>>>> BTW, why you change this, does this world not well in your
>>>>>>>> envrionment?
>>>>>>>> Correct. I got an error, and the comment was not
>>>>>> deleted. After
>>>>>>>> taking off the "s[]" it worked fine. I realized last
>>>> night that I
>>>>>>>> should double check that it works even if I own two blogs,
>>>>>> and I will
>>>>>>>> do that shortly.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>> **************************************************************
>>>>>>>> * * During the first day
>> of my *
>>>>>>>> * Jon Daley * human-anatomy
>> course at *
>>>>>>>> * * Brigham Young
>> University, our *
>>>>>>>> * http://jon.limedaley.com/ * professor said we
>> would be *
>>>>>>>> * * studying real human
>> cadavers. *
>>>>>>>> * * He then told us
>> about the *
>>>>>>>> * * unusual experience of
>> driving *
>>>>>>>> * * a large refrigerated
>> truck *
>>>>>>>> * * cross-country to
>> transpot the *
>>>>>>>> * * cadavers to our
>> campus. One *
>>>>>>>> * * student raised his
>> hand and *
>>>>>>>> * * asked, "Did you get
>> to use *
>>>>>>>> * * the car-pool
>> lane?" *
>>>>>>>> * * -- Diane
>> Chatwin *
>>>>>>>>
>> **************************************************************
>>>>>>>> _______________________________________________
>>>>>>>> pLog-svn mailing list
>>>>>>>> pLog-svn at devel.plogworld.net
>>>>>>>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> pLog-svn mailing list
>>>>>>> pLog-svn at devel.plogworld.net
>>>>>>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>>>>>>
>>>>>>
>>>>>> **************************************************************
>>>>>> * Jon Daley * Teachers open the door, but *
>>>>>> * * you must enter by yourself. *
>>>>>> * http://jon.limedaley.com/ * -- Chinese Proverb *
>>>>>> **************************************************************
>>>>>> _______________________________________________
>>>>>> pLog-svn mailing list
>>>>>> pLog-svn at devel.plogworld.net
>>>>>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>>>>
>>>>> _______________________________________________
>>>>> pLog-svn mailing list
>>>>> pLog-svn at devel.plogworld.net
>>>>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>>>>>
>>>>
>>>> **************************************************************
>>>> * * I have opinions of my own, *
>>>> * Jon Daley * strong opinions, but I don't *
>>>> * * always agree with them. *
>>>> * http://jon.limedaley.com/ * -- George Bush *
>>>> * * *
>>>> **************************************************************
>>>> _______________________________________________
>>>> pLog-svn mailing list
>>>> pLog-svn at devel.plogworld.net
>>>> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
> _______________________________________________
> pLog-svn mailing list
> pLog-svn at devel.plogworld.net
> http://devel.plogworld.net/mailman/listinfo/plog-svn
>
**************************************
Jon Daley
http://jon.limedaley.com/plog/
To err is human,
to forgive divine.
-- Alexander Pope
More information about the pLog-svn
mailing list